-
Notifications
You must be signed in to change notification settings - Fork 4
Implement first version of QA-turned-QC code for ROI mis-locating #1336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Create QC jsons, and add to metadata folder, and then they will show up in the QC portal |
Draft done (a reproducible capsule can be found here). The ideas is to visualize RawData (binary movie) + Experimenter Defined ROIs to check if ROIs are properly covering each fibre (+ empty space for floor signal recording). QA/QC view for a corresponding session: (clearly, ROIs in the Red channel are off) Several discussion points: |
Agree, I would create a quality_control.json using code run on the DAQ PC. If you would prefer to defer this to the upload process, we can add a "job type" to the Data Transfer Service that computes this on the HPC before upload. |
Makes sense to run on the acquisition computer. @hagikent Can this check run before the session runs so we can address the issue before we collect data? Or is the idea to detect issues that happen during the session? |
@dyf
Ok, then I will ditch CO and make a local .py version of this including generating QCs corresponding to this QA. |
Practically, it's impossible to do QA while having human in the loop before uploading. Thus, we agreed to make this just a part of QC pipeline. I will work on integrating the draft to the fip-raw-qc capsule and also set up a capsule to perform signal re-extraction (new ToDo item here: https://github.com/AllenNeuralDynamics/aind-physio-arch/issues/516). |
@hagikent are you still working on this? Any status update you can provide? |
Yes! When I have time to work on pipeline stuff, this would be the 1st thing I would do! Likely next week. |
No description provided.
The text was updated successfully, but these errors were encountered: