Fix - Make Remote runtime use /start for both new and resume #8564
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End-user friendly description of the problem this fixes or functionality this introduces.
Summarize what the PR does, explaining any non-trivial design decisions.
Simplify remote runtime by calling the
/start
endpoint on both new runtimes and resumes, since runtime-api can handle both cases this was duplicating the server-side logic.We've recently seen trouble resuming Remote runtimes in OpenHands Cloud, which may be related to multiple being created in a race condition, so the hope is to improve consistency by letting runtime-api decide which existing runtime to use if any.
An error associated is
Logged from here:
OpenHands/openhands/runtime/impl/remote/remote_runtime.py
Line 121 in 2693360
This will ignore the
attach_to_existing
option on create (not on close). That was added in #4329 (Oct 2024) and I don't think it currently adds anything useful on RemoteRuntime create, but @tofarr and @rbren may have more context.Link of any specific issues this addresses:
To run this PR locally, use the following command: