Skip to content

chore(frontend): Remove making a query to the balance API to check for a 402 error #8542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amanape
Copy link
Member

@amanape amanape commented May 16, 2025

  • This change is worth documenting at https://docs.all-hands.dev/
  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

End-user friendly description of the problem this fixes or functionality this introduces.
This was introduced in #7098, I don't remember why, most likely a mistake


Summarize what the PR does, explaining any non-trivial design decisions.


Link of any specific issues this addresses:


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:81f013c-nikolaik   --name openhands-app-81f013c   docker.all-hands.dev/all-hands-ai/openhands:81f013c

@amanape amanape requested a review from rbren as a code owner May 16, 2025 15:24
@amanape amanape self-assigned this May 16, 2025
@rbren
Copy link
Collaborator

rbren commented May 16, 2025

@amanape can you describe more why we need this?

@amanape
Copy link
Member Author

amanape commented May 16, 2025

It's more of a "why we don't need this", it didn't make sense to call the balance query in the home screen, let alone to use it to check for 402s

It adds a source of confusion in our logs since it makes it look like the user was making a balance-related query when they were just in the home screen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants