Removed duplicated nodeRef property

[iarroyo]

No description provided.

[esplinr]

@iarroyo Can you provide some background on why you propose this change?

[iarroyo]

Hi @esplinr, sure.
Because this property is twice, and there is no point to have the same property two times.
Also some java JSON libraries like org.json doesn't manage the duplicate keys in json objects and throw an exception.

https://github.com/iarroyo/share/blob/b777916fd227f76e26fb8456651ba761671cd044/share-services/src/main/resources/alfresco/templates/webscripts/org/alfresco/slingshot/node-browser/node-browser.get.json.ftl#L47

[esplinr]

Thank you for the clarification, but I don't see the duplicate. Can you provide the line numbers?

[iarroyo]

Sure, lines 33 and 48

https://github.com/Alfresco/share/blob/master/share-services/src/main/resources/alfresco/templates/webscripts/org/alfresco/slingshot/node-browser/node-browser.get.json.ftl#L33

https://github.com/Alfresco/share/blob/master/share-services/src/main/resources/alfresco/templates/webscripts/org/alfresco/slingshot/node-browser/node-browser.get.json.ftl#L48

The previous link i sent is the one from my PR that is why you don't see the duplicates.
Cheers.

[esplinr]

Thank you. It's all clear now.

Can you create an ALF issue linking to this pull request? It doesn't need to have any details, but I need you to check the box to accept the Alfresco Contribution Agreement. You will be the first person to go through our new process! Let me know if you have any feedback on it.

Thank you again for reporting this issue.

[iarroyo]

@esplinr the jira issue was created https://issues.alfresco.com/jira/browse/ALF-21931

[esplinr]

Thank you Ivan. We will get this scheduled.