Skip to content

fix: add the correct type to events #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: add the correct type to events #248

wants to merge 2 commits into from

Conversation

mesqueeb
Copy link

this adds the correct types to the emit events of the VueDraggable component.

  • current (incorrect) behavior: it says the events all have SortableEvent as emit payload type.
  • new (correct) behavior: the event payloads all have the DraggableEvent<T> type which extends SortableEvent.

@netlify Netlify
Copy link

netlify bot commented May 25, 2025 •
edited
Loading

✅ Deploy Preview for vue-draggable-plus ready!

Name Link
🔨 Latest commit 846427e
🔍 Latest deploy log https://app.netlify.com/projects/vue-draggable-plus/deploys/683398c95378980008d276da
😎 Deploy Preview https://deploy-preview-248--vue-draggable-plus.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mesqueeb
Copy link
Author

@Alfred-Skyblue what do you think of this pr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mesqueeb @Alfred-Skyblue