Skip to content

o4-mini was repeated multiple times and prevented applying custom configs #4154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

00sapo
Copy link

@00sapo 00sapo commented Jun 2, 2025

Currently, custom configs are applied to the first model having a specific name found in MODEL_SETTINGS.

However, it's not obvious that it's the same model that will be picked up for chatting.

I noticed this for o4-mini, but it may happen for other models also.

Another solution could be transforming the list into a dict.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants