o4-mini
was repeated multiple times and prevented applying custom configs
#4154
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, custom configs are applied to the first model having a specific name found in
MODEL_SETTINGS
.However, it's not obvious that it's the same model that will be picked up for chatting.
I noticed this for
o4-mini
, but it may happen for other models also.Another solution could be transforming the list into a dict.