Add Clojure repomap queries #4028
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrett-hopper
changed the title
garrett-hopper
changed the title
|
Fixes #3416 |
garrett-hopper
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Definitions: symbol name (without namespace) immediately following a
defprefixed symbolReferences: symbol name (without namespace) found anywhere
The definitions is pretty good; using
defprefix is a very standard Clojure pattern even for 3rd party macros.References is less than ideal, as it causes building the repo map to be a bit slow. The alternative would be to treat only symbols as the first entry in a
list_litas a reference. This works, but I've gotten better results allowing every symbol to contribute to the ranking of definitions.Also added kebab-case as a condition to contribute a definition's ranking. It shouldn't impact most other languages, as
-is typically unary operation and not allowed in idents.