Skip to content

Fix missing regenerator #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wojnilowicz
Copy link
Contributor

@wojnilowicz wojnilowicz commented May 7, 2025

Important

Add missing regenerator dependency to package.json.

  • Dependencies:
    • Add regenerator version ^0.14.12 to dependencies in package.json.

This description was created by Ellipsis for fecff38. You can customize this summary. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Changes requested ❌

Reviewed everything up to fecff38 in 1 minute and 25 seconds. Click for details.
  • Reviewed 12 lines of code in 1 files
  • Skipped 1 files when reviewing.
  • Skipped posting 2 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. package.json:57
  • Draft comment:
    Double-check: Should this dependency be 'regenerator-runtime' instead of 'regenerator'? It’s common to use regenerator-runtime for generators.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 20% vs. threshold = 50% While regenerator-runtime is more common, I don't have definitive proof that regenerator won't work. The comment is phrased as a question/verification request which violates our rules. We don't want to ask authors to "double-check" things. Additionally, this is a dependency change which our rules say we should not comment on. The suggestion could be correct - regenerator-runtime is the standard package. By removing this comment we might miss catching a genuine mistake. Per our rules, we should not comment on dependency changes unless we have strong evidence of an issue. The phrasing as a verification request also violates our guidelines. Delete the comment since it violates our rules about commenting on dependencies and making verification requests.
2. package.json:57
  • Draft comment:
    The new dependency is added as "regenerator". Please double-check that this is the correct package name. Often, the intended package is "regenerator-runtime". If "regenerator" is indeed correct, consider adding a comment for clarity.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% The comment is about a dependency change. According to the rules, we should not comment on dependency changes or library versions we don't recognize. Even if the suggestion might be correct, dependency choices are up to the author and we don't have enough context to know if 'regenerator' was specifically chosen for a reason. The comment could be helpful since regenerator-runtime is indeed more commonly used with Babel, and this might prevent a future issue. However, the rules explicitly state not to comment on dependency changes or library versions we don't recognize. We should trust the author's choice of dependencies. Delete the comment as it violates the rule about not commenting on dependency changes.

Workflow ID: wflow_3phZ9pvCAlLxZ416

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

package.json Outdated
@@ -54,6 +54,7 @@
"papaparse": "^5.3.2",
"pinia": "^2.0.13",
"propagating-hammerjs": "^1.4.7",
"regenerator": "^0.14.12",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verify package name: typically, regenerator-runtime is used, not regenerator.

Suggested change
"regenerator": "^0.14.12",
"regenerator-runtime": "^0.14.12",

Copy link

codecov bot commented May 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.70%. Comparing base (9259df7) to head (98e23fd).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #677   +/-   ##
=======================================
  Coverage   26.70%   26.70%           
=======================================
  Files          28       28           
  Lines        1659     1659           
  Branches      281      294   +13     
=======================================
  Hits          443      443           
+ Misses       1190     1158   -32     
- Partials       26       58   +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wojnilowicz wojnilowicz force-pushed the fix-missing-regenerator branch from fecff38 to 98e23fd Compare May 7, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant