✨ Infer HTTP success status code from openapi spec #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelsvagr
requested changes
Dec 2, 2025
| if (pathSpec[method]?.operationId) { | ||
| const operationResponses = pathSpec[method].responses ?? {} | ||
| const successStatus = | ||
| Object.keys(operationResponses).find(status => |
Member
There was a problem hiding this comment.
question: What about redirects (3xx)?
| if (operationId && !res.headersSent) { | ||
| const metadata = operationPaths[operationId] | ||
| if (metadata?.successStatus) { | ||
| res.status(metadata.successStatus) |
Member
There was a problem hiding this comment.
issue: This will overwrite the status user set right?
Imagine having two possible success statuses for operation (200 and 2xx or 200 and 3xx) for example based on Accept header of the client request. If the dev sets the status before the async handler is called, this will overwrite it to 200.
Collaborator
Author
There was a problem hiding this comment.
Good catch, I moved the status code assignment before we execute the operation handler, so anything set by user will overwrite it.
…ent the overwrite of explicit status code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR addresses: