Skip to content

Fixed an error that occurred when compiling the executable file (#5068)#5069

Open
snowman20230101 wants to merge 1 commit into
AOMediaCodec:mainfrom
snowman20230101:main
Open

Fixed an error that occurred when compiling the executable file (#5068)#5069
snowman20230101 wants to merge 1 commit into
AOMediaCodec:mainfrom
snowman20230101:main

Conversation

@snowman20230101

Copy link
Copy Markdown

#5068

This fixes app-only builds where ENABLE_APPS=ON but ENABLE_TESTS,
ENABLE_EXAMPLES, and ENABLE_TOOLS are OFF. avmdec/avmenc still need
libyuv/webm include paths and object sources.

Verified locally:
cmake --build build_fast --target avmdec -j8
cmake --build build_fast --target avmenc -j8

@snowman20230101

Copy link
Copy Markdown
Author

https://aomedia.org/about/legal/

I have signed the CLA, thanks.

@urvangjoshi

Copy link
Copy Markdown
Contributor

https://aomedia.org/about/legal/

I have signed the CLA, thanks.

Thanks! Let's wait for it to come through (should be soon). Then, I'll rebase the PR and the CLA bot should rerun.

@snowman20230101 snowman20230101 force-pushed the main branch 3 times, most recently from ee2421f to 3b33450 Compare June 13, 2026 08:13
@snowman20230101

Copy link
Copy Markdown
Author

https://aomedia.org/about/legal/
I have signed the CLA, thanks.

Thanks! Let's wait for it to come through (should be soon). Then, I'll rebase the PR and the CLA bot should rerun.

I confirmed that my AOM Individual CLA was completed via DocuSign.

GitHub username: snowman20230101
Commit author email: burniceer@gmail.com
Individual CLA DocuSign Envelope ID: F87E7749-E346-4942-8175-CDAA48ECF5AF
Signed/completed: 2026-06-13 12:40 PDT

The PR's commit author email matches the CLA email, but the CLA bot still reports "CLA has not been signed yet".
Could someone please check whether my CLA record has been imported and associated with this GitHub account/email, then rerun the CLA check ?

Thanks!

@urvangjoshi

Copy link
Copy Markdown
Contributor

@leolzhao @Krishna-Rapaka can check.
@jzern FYI

@urvangjoshi urvangjoshi requested review from jzern and leolzhao June 13, 2026 18:47
@jzern

jzern commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

I don't think the CLA is going through because the mailing address doesn't look correct. It's just a multi-line string of ascii characters with no whitespace.

@snowman20230101

Copy link
Copy Markdown
Author

I don't think the CLA is going through because the mailing address doesn't look correct. It's just a multi-line string of ascii characters with no whitespace.

Okay, I'll check it, or I might need to re-sign a CLA.

Thanks!

@snowman20230101 snowman20230101 force-pushed the main branch 2 times, most recently from c99a08f to 05a2159 Compare June 16, 2026 08:58
@leolzhao

Copy link
Copy Markdown
Contributor

Commit author email:

Based on my understanding, we need to use the company email address to sign the CLA rather than gmail address. Please correct me if I'm wrong. @urvangjoshi @jzern

@jzern

jzern commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Commit author email:

Based on my understanding, we need to use the company email address to sign the CLA rather than gmail address. Please correct me if I'm wrong. @urvangjoshi @jzern

Individual contributors can use any email address. They don't have to be a part of an AOMedia member organization.

@snowman20230101

Copy link
Copy Markdown
Author

Commit author email:

Based on my understanding, we need to use the company email address to sign the CLA rather than gmail address. Please correct me if I'm wrong. @urvangjoshi @jzern

Individual contributors can use any email address. They don't have to be a part of an AOMedia member organization.

What should I do next? I'm contributing personally, not through a company. So I thought I should sign the CLA agreement personally. But here's the situation: the CLA can't pass the automated review.

@urvangjoshi

Copy link
Copy Markdown
Contributor

I don't think the CLA is going through because the mailing address doesn't look correct. It's just a multi-line string of ascii characters with no whitespace.

@snowman20230101 : I just checked and the issue is still the same as what @jzern mentioned before (quoted below).

I don't think the CLA is going through because the mailing address doesn't look correct. It's just a multi-line string of ascii characters with no whitespace.

Pls sign CLA again and make sure that you provide a valid mailing address.

@snowman20230101

Copy link
Copy Markdown
Author

I don't think the CLA is going through because the mailing address doesn't look correct. It's just a multi-line string of ascii characters with no whitespace.

@snowman20230101 : I just checked and the issue is still the same as what @jzern mentioned before (quoted below).

I don't think the CLA is going through because the mailing address doesn't look correct. It's just a multi-line string of ascii characters with no whitespace.

Pls sign CLA again and make sure that you provide a valid mailing address.

Thanks.

I've re-signed it. I noticed the form is different from the previous one. Hopefully, it will pass this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants