Add method to calculate input for a trampoline fee#589
Open
Add method to calculate input for a trampoline fee#589
Conversation
This method returns the amount that needs to be provided to the trampoline payment handler in order to entirely consume a given amount, without leaving any dust. This allows the node to send all their balance over LN.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a method in
TrampolineFeethat returns the exact amount that must be provided to the trampoline payment handler in order to entirely consume a given amount, without leaving any dust.Specifically, this will allow a Phoenix wallet to send all its balance over LN.
Also, tests have been added for the existing
Trampoline.calculateFeesmethodExample:
1_000_000 sat4 sat + 0.4%992_032 msat, the fee would be7_968 msat.