Skip to content

Return property mapping on get#5

Open
Mojken wants to merge 1 commit into5monkeys:mainfrom
Mojken:main
Open

Return property mapping on get#5
Mojken wants to merge 1 commit into5monkeys:mainfrom
Mojken:main

Conversation

@Mojken
Copy link
Copy Markdown

@Mojken Mojken commented Nov 11, 2021

I'm not entirely sure if this is something you want to allow, but since it closes #4, until there's a better solution this is better than nothing.

Copy link
Copy Markdown
Contributor

@antonagestam antonagestam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, I just left two minor comments.

Comment thread tests/test_properties.py
Comment on lines +32 to +33

def test_getting_enum_property() -> None:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def test_getting_enum_property() -> None:
def test_getting_enum_property() -> None:

I think black will complain here?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def test_getting_enum_property() -> None:
def test_can_introspect_property_attributes() -> None:

Let's name the test so that the aspect we're testing is clear.

@antonagestam
Copy link
Copy Markdown
Contributor

Merging main should solve the CI issue (was lacking a pin of the Python version, fixed here: #7)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow introspection of property mapping

2 participants