The model form are supported in the formapi and details

[goinnn]

1. Now the model form are supported in the formapi.
2. A simple way to pass the request to your form (request_passed)
3. If you overwrite the get_form_kwargs method you can pass more parameters to your form
4. And some details: reorder the imports, change API.xxx to cls.xxx or self.xxx, remove the clean method from APICall, etc

[goinnn]

@hannseman Something about this?

[andreif]

@goinnn What about failing tests?

    self._errors[forms.NON_FIELD_ERRORS] = errors
AttributeError: 'module' object has no attribute 'NON_FIELD_ERRORS'

[goinnn]

@andreif So sorry I don't see this error

[andreif]

@goinnn Great, thanks! I am not familiar with this project though, so I would wait @hannseman and @carlmarten to comment. However, I feel like some extra tests are required since you are adding new things here.

[goinnn]

@andreif Ok, thanks!.

@hannseman or @carlmarten when you see it please tell me something about the tests... if this pull request needs tests, and What are the necessary tests?

[hannseman]

Hey @goinnn! Thanks for the PR. Please add tests for the APIModelCall, like updating first_name and last_name on a django.contrib.auth.User with and test customizing the instance_pk_param.

[hannseman]

Is there a reason why you're serializing the object in the form and not letting render_to_json_response handle this? I don't think we should have two ways to serialize data returned from action()

[hannseman]

I'm also thinking about the whole choosing if you want request passed to your APICalls. What we skipped setting request_passed = False and always pass request as a kwarg and do something like this:

class API(FormView):
    def get_form_kwargs(self):
        kwargs = super(API, self).get_form_kwargs()
        form_class = self.get_form_class()
        if self.request:
            kwargs['request'] = self.request
        if isinstance(form_class, APIModelCall):
            kwargs.update(self._get_model_form_kwargs())
        return kwargs

class APICall(forms.Form):
    def __init__(self, request=None, *args, **kwargs):
        super(APICall, self).__init__(*args, **kwargs)
        self.request = request

I might not be thinking of all use cases but this shouldn't hurt backwards compatibility. What do you think?

[Brettbadboy]

Ineed help