Does pugixml need to hide pragma checks?

[pachadotdev]

I am curious about this line

pugixml/src/pugixml.cpp

Line 57 in f1f532a

# pragma clang diagnostic push

When we use pugixml with R, the R checks say

*** checking pragmas in C/C++ headers and code ... NOTE**
File which contains pragma(s) suppressing diagnostics:
  'src/vendor/pugixml.cpp'

[zeux]

Not sure what you mean by "hide", but push/pop is used to avoid warning configuration leaking into the parent translation unit in case header mode is used (when .cpp file is included instead of being compiled separately).

[pachadotdev]

"hide" as in "suppressing"

thanks for your answer

pugixml is amazing, I used it as an alternative to Apache Xerces because I cannot use AX with R

furthermore, pugixml works on Windows, which is more amazing