Skip further checks in case of empty domain part

andreasschroth · web-flow · commit fd3d55003b2d · 2018-10-03T13:02:48.000+02:00
Fixes issue #240
diff --git a/src/Hostname.php b/src/Hostname.php
@@ -2098,6 +2098,13 @@ public function isValid($value)
                                 return false;
                             }
                         }
+                        
+                        // Stop with following checks if domain part is empty, as it definitely is not a valid hostname then
+                        if ($domainPart === '') {
+                            $this->error(self::INVALID_HOSTNAME);
+                            $status = false;
+                            break 2;
+                        }
 
                         // Check dash (-) does not start, end or appear in 3rd and 4th positions
                         if ($utf8StrWrapper->strpos($domainPart, '-') === 0

Original file line number	Diff line number	Diff line change
`@@ -2098,6 +2098,13 @@ public function isValid($value)`
`2098`	`2098`	`return false;`
`2099`	`2099`	`}`
`2100`	`2100`	`}`
	`2101`	`+`
	`2102`	`+ // Stop with following checks if domain part is empty, as it definitely is not a valid hostname then`
	`2103`	`+ if ($domainPart === '') {`
	`2104`	`+ $this->error(self::INVALID_HOSTNAME);`
	`2105`	`+ $status = false;`
	`2106`	`+ break 2;`
	`2107`	`+ }`
`2101`	`2108`
`2102`	`2109`	`// Check dash (-) does not start, end or appear in 3rd and 4th positions`
`2103`	`2110`	`if ($utf8StrWrapper->strpos($domainPart, '-') === 0`