Merge pull request #54 from rapidsoft-de/fix-hostname-with-only-ip-chars

Prevent IP validation from being triggered for hostnames that only contain IP chars

Author: weierophinney

src/Hostname.php

@@ -1671,7 +1671,8 @@ public function isValid($value)
 
         $this->setValue($value);
         // Check input against IP address schema
-        if (preg_match('/^[0-9a-f:.]*$/i', $value)
+        if (((preg_match('/^[0-9.]*$/', $value) && strpos($value, '.') !== false)
+                || (preg_match('/^[0-9a-f:.]*$/i', $value) && strpos($value, ':') !== false))
             && $this->getIpValidator()->setTranslator($this->getTranslator())->isValid($value)
         ) {
             if (!($this->getAllow() & self::ALLOW_IP)) {

test/HostnameTest.php

@@ -527,4 +527,10 @@ public function testEqualsMessageVariables()
         $validator = $this->validator;
         $this->assertAttributeEquals($validator->getOption('messageVariables'), 'messageVariables', $validator);
     }
+
+    public function testHostnameWithOnlyIpChars()
+    {
+        $validator = new Hostname();
+        $this->assertTrue($validator->isValid('cafecafe.de'));
+    }
 }