Skip to content

Commit 1e24b30

Browse files
author
Christopher Goddard
committed
Consume app_id on app registration + pass /w user-agent on request
- Let's ensure that we know which app made a given request by encoding within the user-agent - This will help /w ascertaining who is making a given request
1 parent 3a9251d commit 1e24b30

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

lib/client.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -333,6 +333,7 @@ export default class Client {
333333
this._metadata = null
334334
this._context = options.context || null
335335
this._idleState = null
336+
this.appId = null
336337
this.ready = false
337338

338339
if (!isOriginValid(this._origin)) {
@@ -350,6 +351,7 @@ export default class Client {
350351

351352
this.on('app.registered', (data) => {
352353
this.ready = true
354+
this.appId = data.appId
353355
this._metadata = data.metadata
354356
this._context = data.context
355357
this._idleState = new IdleState()

lib/utils.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,13 @@ import pkgJson from '../package.json'
33

44
const Promise = window.Promise || NativePromise
55

6-
export function addUserAgent (headers) {
6+
export function addUserAgent (headers, appId) {
77
const originalUserAgent = headers && headers['User-Agent'] ? headers['User-Agent'] : ''
8+
const zafSdkUserAgentString = `zendesk_app_framework_sdk/sdk_version:${pkgJson.version}/app_id:${appId}`
9+
const userAgent = originalUserAgent ? `${originalUserAgent} ${zafSdkUserAgentString}` : zafSdkUserAgentString
810
return {
911
...headers,
10-
'User-Agent': originalUserAgent ? `${originalUserAgent} zendesk_app_framework_sdk/${pkgJson.version}` : `zendesk_app_framework_sdk/${pkgJson.version}`
12+
'User-Agent': userAgent
1113
}
1214
}
1315

0 commit comments

Comments
 (0)