Skip to content

Commit 1a47a59

Browse files
author
Chris Goddard
committed
Add pull request template and add recovery section to DEPLOY.md
1 parent 93258b0 commit 1a47a59

File tree

2 files changed

+60
-0
lines changed

2 files changed

+60
-0
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 47 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,47 @@
1+
:v:
2+
3+
/cc @zendesk/vegemite
4+
5+
### Description
6+
Describe the original problem and the changes made on this PR.
7+
8+
### Tasks
9+
- [ ] Include comments/inline docs where appropriate
10+
- [ ] Add [unit tests](/spec)
11+
- [ ] Update changelog [here](https://github.com/zendesk/zaf_docs/blob/master/doc/v2/dev_guide/changelog.md)
12+
13+
### References
14+
* JIRA: https://zendesk.atlassian.net/browse/VEG-XXX
15+
16+
### DevQA Steps
17+
18+
<!-- The DevQA process is to assess whether the work meets its acceptance criteria. If the acceptance criteria are unclear, the DevQA should verify with the code owner or the person who created the Jira card. To start with DevQA, deploy this branch to [staging](https://samson.zende.sk/projects/zendesk_app_framework/stages/static-assets-build) environment. -->
19+
20+
- Make sure [Zendesk Apps Framework regression tests](https://zendesk.atlassian.net/wiki/spaces/ENG/pages/641702848/DevQA+process+in+Vegemite#DevQAprocessinVegemite-regression-checks) are passing with this change.
21+
- Add specific DevQA instructions here ....
22+
23+
NOTE: DevQA steps are to be actioned only once code has been reviewed and approved.
24+
25+
### Risks
26+
* [HIGH | medium | low] Does it work across browsers (including IE!)?
27+
* [HIGH | medium | low] Does it work in the different products (Support, Chat, Connect)?
28+
* [HIGH | medium | low] Are there any performance implications?
29+
* [HIGH | medium | low] Any security risks?
30+
* [HIGH | medium | low] What features does this touch?
31+
32+
### Rollback Plan
33+
34+
1. Quickly [roll back] to the prior release so that customers can refresh to resolve their issue.
35+
1. Revert this PR to restore the master branch to a deployable green state.
36+
1. Notify the author.
37+
38+
[roll back]: https://github.com/zendesk/zendesk_app_framework_sdk/blob/master/DEPLOY.md#recovery
39+
40+
<!--
41+
List any additional tasks to perform if this PR is reverted. Examples:
42+
* Run a backfill to alter changed data structures
43+
* Roll back state of any co-dependent feature flags
44+
* Revert a PR changing an API endpoint in another repo
45+
* Inform particular customers, PMs, and/or stakeholders
46+
* Note any non-obvious consequence of reversion
47+
-->

DEPLOY.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,16 @@
11
# Deployment 🚀
22

33
For instructions on how to deploy, see [zaf_sdk_deployment](https://github.com/zendesk/zaf_sdk_deployment).
4+
5+
## Recovery
6+
7+
**The default action that should be taken to respond to an incident caused by a recent ZAF SDK deployment is _a rollback_.** Do not hesitate to perform a rollback if prior releases do not exhibit the defect in question.
8+
9+
To roll back to a previous version, use the [App Framework SDK deploys](https://samson.zende.sk/projects/zendesk_app_framework_sdk/stages/static-assets-switch-major) stage to deploy a previously deployed tag.
10+
11+
_Note: This pipeline should **only** be used to respond to incidents._
12+
13+
1. Notify @vegemite on #ask-vegemite of any ongoing incidents and whether you intend to rollback a deploy.
14+
1. Look at recent [App Framework SDK deploys](https://samson.zende.sk/projects/zendesk_app_framework_sdk/stages/static-assets-switch-major) to production.
15+
1. Deploy the previous tag.
16+
1. Notify @vegemite on #ask-vegemite once the rollback is complete.

0 commit comments

Comments
 (0)