feat: Clean up filepanel access

Author: lazysegtree

src/internal/file_panel.go

@@ -521,3 +521,10 @@ func (panel *FilePanel) RefreshData(displayDotFile bool) {
 	}
 	panel.LastTimeGetElement = time.Now()
 }
+
+func (panel *FilePanel) ResetIndexIfInvalid() {
+	if panel.Cursor < 0 || panel.Cursor >= panel.ElementCount() {
+		panel.Cursor = 0
+		panel.RenderIndex = 0
+	}
+}

src/internal/model.go

@@ -436,9 +436,7 @@ func (m *model) updateFilePanelsState(msg tea.Msg) tea.Cmd {
 
 	// TODO : This is like duct taping a bigger problem
 	// The code should never reach this state.
-	if focusPanel.Cursor < 0 {
-		focusPanel.Cursor = 0
-	}
+	focusPanel.ResetIndexIfInvalid()
 
 	return cmd
 }

src/internal/model_navigation_test.go

@@ -124,7 +124,6 @@ func TestFilePanelNavigation(t *testing.T) {
 			m := defaultTestModel(tt.startDir)
 			m.getFocusedFilePanel().Cursor = tt.startCursor
 			m.getFocusedFilePanel().RenderIndex = tt.startRender
-			m.getFocusedFilePanel().SearchBar.SetValue("asdf")
 			for _, s := range tt.keyInput {
 				TeaUpdateWithErrCheck(m, utils.TeaRuneKeyMsg(s))
 			}
@@ -141,7 +140,7 @@ func TestFilePanelNavigation(t *testing.T) {
 			TeaUpdateWithErrCheck(m, utils.TeaRuneKeyMsg("cd "+tt.startDir))
 			TeaUpdateWithErrCheck(m, tea.KeyMsg{Type: tea.KeyEnter})
 
-			// Make sure we have original curson and render
+			// Make sure we have original cursor and render
 			assert.Equal(t, tt.startCursor, m.getFocusedFilePanel().Cursor)
 			assert.Equal(t, tt.startRender, m.getFocusedFilePanel().RenderIndex)
 		})

src/internal/model_render.go

@@ -32,11 +32,7 @@ func (m *model) filePanelRender() string {
 		// check if cursor or render out of range
 		// TODO - instead of this, have a filepanel.validateAndFix(), and log Error
 		// This should not ever happen
-		if filePanel.Cursor > filePanel.ElementCount()-1 {
-			filePanel.Cursor = 0
-			filePanel.RenderIndex = 0
-		}
-		m.fileModel.filePanels[i] = filePanel
+		m.fileModel.filePanels[i].ResetIndexIfInvalid()
 
 		// TODO : Move this to a utility function and clarify the calculation via comments
 		// Maybe even write unit tests