Skip to content

[Bug?]: selective binary by OS and Node version #6565

@rtritto

Description

@rtritto

Self-service

  • I'd be willing to implement a fix

Describe the bug

After uWebSockets.js is installed, all OS and Node versions are built.

To reproduce

  • yarn init -y
  • yarn set version berry
  • yarn add uWebSockets.js@github:uNetworking/uWebSockets.js#v20.49.0
  • open directory /.yarn/unplugged/uWebSockets.js-https-<HASH>/node_modules/uWebSockets.js
  • .node files are 24 (uws_darwin_, uws_linux, uws_win32*)

Expected

In directory /.yarn/unplugged/uWebSockets.js-https-<HASH>/node_modules/uWebSockets.js there is only 1 file filtered by OS and Node version

Environment

System:
OS: Windows 11 10.0.22631
Binaries:
Node: 22.9.0 - ~\AppData\Local\Temp\xfs-7275780b\node.CMD
Yarn: 4.5.1 - ~\AppData\Local\Temp\xfs-7275780b\yarn.CMD
npm: 10.8.3 - C:\Program Files\nodejs\npm.CMD

Additional context

Related comment uNetworking/uWebSockets.js#1112 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingexternal bugThis issue highlights a bug in another project

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions