Skip to content

Commit 08f458c

Browse files
authored
Merge pull request #10 from xaos7991/chore/docs-update-pnpm-comments
docs: updated comments to reflect pnpm usage instead of yarn
2 parents 0fe7f92 + a6f9007 commit 08f458c

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

packages/integration-tests/tools/pack-packages.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -130,13 +130,13 @@ export const setup = async (project: TestProject): Promise<void> => {
130130
),
131131
{ encoding: 'utf-8' },
132132
);
133-
// TODO!: Rewrite
134-
// We install the tarballs here once so that yarn can cache them globally.
133+
134+
// We install the tarballs here once so that pnpm can cache them globally.
135135
// This solves 2 problems:
136136
// 1. Tests can be run concurrently because they won't be trying to install
137137
// the same tarballs at the same time.
138-
// 2. Installing the tarballs for each test becomes much faster as Yarn can
139-
// grab them from the global cache folder.
138+
// 2. Installing the tarballs for each test becomes much faster as pnpm can
139+
// reuse them from its global content-addressable store.
140140
await execFile('pnpm', ['install', '--no-frozen-lockfile'], {
141141
cwd: temp,
142142
shell: true,

tools/scripts/postinstall.mts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,10 @@ import { $ as $_config } from 'execa';
22

33
const $ = $_config({
44
env: {
5-
// TODO!: Check it out and, if necessary, rewrite it
65
/**
76
* Do not apply the special GitHub Actions group markers within the
87
* postinstall logging, it cannot work correctly when nested within
9-
* yarn's output and therefore just adds visual noise.
8+
* pnpm's output and therefore just adds visual noise.
109
*/
1110
NX_SKIP_LOG_GROUPING: 'true',
1211
},

0 commit comments

Comments
 (0)