Refactoring the codegen module

[kezhenxu94]

At the moment, we generate the code by manipulating string directly, which is very verbose and hard to extend, sometimes is easy to generate buggy code, so I would suggest refactoring the codegen module, proposals includes:

• rewriting the codegen module using some patterns, I found the the Visitor Pattern is the best choice here.

• rewriting the codegen module using some other codegen library, such as kotlinpoet

This may need much work and this is just a proposal.

[wuseal]

@kezhenxu94 Visitor Pattern is a good choice for our Project. And kotlinpoet seems nice, too. We could combine them together.

[rodion-m]

Hello @kezhenxu94 and @wuseal ! It's good idea to migrate to code generator, I think it's a right way.
Also I want to suggest an improvement to give you an ability not to duplicate code generation function: #156 .

[kezhenxu94]

hi @rody66 thanks for your proposal, I'd recommend you put your proposal here together for contributors to refer to, and thanks again for your proposal, will take a.detailed look and discuss later after 3.2.0 released

Posted from mini-github
发送自微信小程序 GitHub 专业版

[wuseal]

Let me describe my previous design or the current two logic of the current code: insert the code and generate a .kt file is basically the same.

1. First, pass the user-entered string and root class name
   The pure string conversion tool KotlinCodeMaker converts the JSON string into the Kotlin Data Class class string.
2. Parses the Kotlin Data Class class string into the ParsedKotlinDataClass data structure through ClassCodeParser.
3. Converts the ParsedKotlinDataClass data structure into the KotlinDataClass data structure.
4. Modify or decorate the data structure.
   The interceptor collection obtained from the InterceptorManager class to modify the KotlinDataClass data (the options for the advanced settings interface are mainly works during this period).
5. Call the getCode method of KotlinDataClass converted to a code string.
6. Insert the code string into the current editor or write to the kotlin file to be generated.

Another: import com.sss.xxx This package declaration is separate from the code generation,Is a separate direct string insertion, no complex logic.

The current purpose of the interceptor function is to decouple the code generation and the functions of configuration options and also to decouple the options each other. In the future, you can organize different interceptor sets through the builder mode.

Then we could base on pre code logic and design a new code structure for support JSONSChema and better extension