Adjust approach to avoid CI hang

Author: dkmyta

app/controllers/core.rb

@@ -37,7 +37,10 @@ def update_db_required?
         return false unless user_interaction? && local_db.outdated?
 
         output('@notice', msg: 'It seems like you have not updated the database for some time.')
-        response = Readline.readline('[?] Do you want to update now? [Y]es [N]o, default: [N] ', true)
+        print '[?] Do you want to update now? [Y]es [N]o, default: [N]'
+        $stdout.flush
+
+        response = $stdin.gets.to_s.strip
 
         !!/^y/i.match?(response)
       end

spec/app/controllers/core_spec.rb

@@ -106,25 +106,19 @@
 
         context 'when the db is outdated' do
           before do
-            allow(core).to receive(:user_interaction?).and_return(true)
             expect(core.local_db).to receive(:outdated?).ordered.and_return(true)
             expect(core.formatter).to receive(:output).with('@notice', hash_including(:msg), 'core').ordered
+            expect($stdout).to receive(:write).ordered # for the print()
           end
 
           context 'when a positive answer' do
-            before do
-              expect(Readline).to receive(:readline).with('[?] Do you want to update now? [Y]es [N]o, default: [N] ',
-                                                          true).and_return('Yes')
-            end
+            before { expect(Readline).to receive(:readline).and_return('Yes').ordered }
 
             its(:update_db_required?) { should eql true }
           end
 
           context 'when a negative answer' do
-            before do
-              expect(Readline).to receive(:readline).with('[?] Do you want to update now? [Y]es [N]o, default: [N] ',
-                                                          true).and_return('No')
-            end
+            before { expect(Readline).to receive(:readline).and_return('no').ordered }
 
             its(:update_db_required?) { should eql false }
           end
@@ -151,12 +145,12 @@
     context 'when --update' do
       before do
         expect(core.formatter).to receive(:output)
-          .with('db_update_started', hash_including(verbose: nil), 'core').ordered
+                                    .with('db_update_started', hash_including(verbose: nil), 'core').ordered
 
         expect_any_instance_of(WPScan::DB::Updater).to receive(:update)
 
         expect(core.formatter).to receive(:output)
-          .with('db_update_finished', hash_including(verbose: nil), 'core').ordered
+                                    .with('db_update_finished', hash_including(verbose: nil), 'core').ordered
       end
 
       context 'when the --url is not supplied' do
@@ -200,16 +194,16 @@
           stub_request(:any, target_url)
 
           expect(core.target).to receive(:homepage_res)
-            .at_least(1)
-            .and_return(Typhoeus::Response.new(effective_url: redirection, body: ''))
+                                   .at_least(1)
+                                   .and_return(Typhoeus::Response.new(effective_url: redirection, body: ''))
         end
 
         context 'to the wp-admin/install.php' do
           let(:redirection) { "#{target_url}wp-admin/install.php" }
 
           it 'calls the formatter with the correct parameters and exit' do
             expect(core.formatter).to receive(:output)
-              .with('not_fully_configured', hash_including(url: redirection), 'core').ordered
+                                        .with('not_fully_configured', hash_including(url: redirection), 'core').ordered
 
             # TODO: Would be cool to be able to test the exit code
             expect { core.before_scan }.to raise_error(SystemExit)