bug symfony#38559 [Lock] Reset lifetime on acquireRead() (Nyholm)

This PR was merged into the 5.x branch.

Discussion
----------

[Lock] Reset lifetime on acquireRead()

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        | n/a

Same as symfony#38553 but this is for `acquireRead()` instead of `acquire()`.

`acquireRead()` is new in 5.2.

Commits
-------

de412bf Reset lifetime on acquireRead()

Author: fabpot

src/Symfony/Component/Lock/Lock.php

@@ -121,6 +121,7 @@ public function acquire(bool $blocking = false): bool
      */
     public function acquireRead(bool $blocking = false): bool
     {
+        $this->key->resetLifetime();
         try {
             if (!$this->store instanceof SharedLockStoreInterface) {
                 $this->logger->debug('Store does not support ReadLocks, fallback to WriteLock.', ['resource' => $this->key]);

src/Symfony/Component/Lock/Tests/LockTest.php

@@ -20,6 +20,7 @@
 use Symfony\Component\Lock\Lock;
 use Symfony\Component\Lock\PersistingStoreInterface;
 use Symfony\Component\Lock\SharedLockStoreInterface;
+use Symfony\Component\Lock\Store\ExpiringStoreTrait;
 
 /**
  * @author Jérémy Derussé <[email protected]>
@@ -429,6 +430,52 @@ public function testAcquireReadNoBlockingWithSharedLockStoreInterface()
         $this->assertTrue($lock->acquireRead(false));
     }
 
+    /**
+     * @group time-sensitive
+     */
+    public function testAcquireReadTwiceWithExpiration()
+    {
+        $key = new Key(uniqid(__METHOD__, true));
+        $store = new class() implements PersistingStoreInterface {
+            use ExpiringStoreTrait;
+            private $keys = [];
+            private $initialTtl = 30;
+
+            public function save(Key $key)
+            {
+                $key->reduceLifetime($this->initialTtl);
+                $this->keys[spl_object_hash($key)] = $key;
+                $this->checkNotExpired($key);
+
+                return true;
+            }
+
+            public function delete(Key $key)
+            {
+                unset($this->keys[spl_object_hash($key)]);
+            }
+
+            public function exists(Key $key)
+            {
+                return isset($this->keys[spl_object_hash($key)]);
+            }
+
+            public function putOffExpiration(Key $key, float $ttl)
+            {
+                $key->reduceLifetime($ttl);
+                $this->checkNotExpired($key);
+            }
+        };
+        $ttl = 1;
+        $lock = new Lock($key, $store, $ttl);
+
+        $this->assertTrue($lock->acquireRead());
+        $lock->release();
+        sleep($ttl + 1);
+        $this->assertTrue($lock->acquireRead());
+        $lock->release();
+    }
+
     public function testAcquireReadBlockingWithBlockingSharedLockStoreInterface()
     {
         $key = new Key(uniqid(__METHOD__, true));