Conversion from Hex to BigNumber

[0xsanson]

Check existing issues

• I checked there isn't already an issue for the bug I encountered.

Viem Version

2.31.0

Current Behavior

Viem tends to interpret numbers written as "0x..." as if they were ascii strings instead of hex numbers. This is causing me a lot of confusion since most wallets and dapps I'm interfacing with are using this format (since it's used by all raw eth_ requests).

For example an user might think the following transaction sends 1 wei, but it actually sends 813183025 wei

await client.sendTransaction({
  account: '0xd8dA6BF26964aF9D7eEd9e03E53415D37aA96045',
  from: '0xd8dA6BF26964aF9D7eEd9e03E53415D37aA96045',
  to: '0xdd974D5C2e2928deA5F71b9825b8b646686BD200',
  value: '0x01',
});

BTW, I know we are supposed to convert to BigNumber ourselves, so this can be considered a feat request, however viem doesn't raise warning or errors if we pass the wrong type (I'm using pure javascript) so it can cause unwanted consequences.

Expected Behavior

Convert "0x01" to 1n.

Steps To Reproduce

import {  serializeTransaction, parseTransaction } from 'viem';

const serialized = serializeTransaction({
  from: '0xd8dA6BF26964aF9D7eEd9e03E53415D37aA96045',
  to: '0xd8dA6BF26964aF9D7eEd9e03E53415D37aA96045',
  value: '0x01',
  type: 'legacy',
});
console.log('value = ', parseTransaction(serialized).value);

This will output value = 813183025n.

Link to Minimal Reproducible Example

No response

Anything else?

No response

[jxom]

We can look into expressing number-compatible properties as hex. Moving to feature request.

[jxom]

For now, I'll fix the case you're encountering.

[jxom]

Fixed on dc2f64a. Will release shortly.