Skip to content

Commit 49eedb0

Browse files
committed
Fix jsx-handler-names regex (fixes jsx-eslint#425)
1 parent 6643f87 commit 49eedb0

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed

lib/rules/jsx-handler-names.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ module.exports = function(context) {
1515
var eventHandlerPrefix = configuration.eventHandlerPrefix || 'handle';
1616
var eventHandlerPropPrefix = configuration.eventHandlerPropPrefix || 'on';
1717

18-
var EVENT_HANDLER_REGEX = new RegExp('^((props\.' + eventHandlerPropPrefix + ')'
19-
+ '|((.*\.)?' + eventHandlerPrefix + ')).+$');
18+
var EVENT_HANDLER_REGEX = new RegExp('^((props\\.' + eventHandlerPropPrefix + ')'
19+
+ '|((.*\\.)?' + eventHandlerPrefix + ')).+$');
2020
var PROP_EVENT_HANDLER_REGEX = new RegExp('^(' + eventHandlerPropPrefix + '.+|ref)$');
2121

2222
return {

tests/lib/rules/jsx-handler-names.js

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,15 @@ ruleTester.run('jsx-handler-names', rule, {
6969
'<TestComponent ref={this.somethingRef} />'
7070
].join('\n'),
7171
parserOptions: parserOptions
72+
}, {
73+
code: [
74+
'<TestComponent test={this.props.content} />'
75+
].join('\n'),
76+
options: [{
77+
eventHandlerPrefix: 'on',
78+
eventHandlerPropPrefix: 'on'
79+
}],
80+
parserOptions: parserOptions
7281
}],
7382

7483
invalid: [{

0 commit comments

Comments
 (0)