Skip to content

Commit 0eee840

Browse files
committed
Removed uneeded TODOs.
1 parent 016347a commit 0eee840

File tree

4 files changed

+1
-13
lines changed

4 files changed

+1
-13
lines changed

src/client/builder.rs

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,6 @@ mod async_imports {
5555
#[cfg(feature="async")]
5656
use self::async_imports::*;
5757

58-
// TODO: add extra funcs for future stuff, like auto ping and auto close
59-
60-
6158
/// Build clients with a builder-style API
6259
/// This makes it easy to create and configure a websocket
6360
/// connection:
@@ -662,7 +659,6 @@ impl<'u> ClientBuilder<'u> {
662659
Box::new(future)
663660
}
664661

665-
// TODO: add timeout option for connecting
666662
// TODO: add conveniences like .response_to_pings, .send_close, etc.
667663
/// Asynchronously create an insecure (plain TCP) connection to the client.
668664
///
@@ -974,6 +970,4 @@ mod tests {
974970
assert!(protos.contains(&"electric".to_string()));
975971
assert!(!protos.contains(&"rust-websocket".to_string()));
976972
}
977-
978-
// TODO: a few more
979973
}

src/codec/ws.rs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,6 @@ use ws::message::Message as MessageTrait;
2424
use ws::util::header::read_header;
2525
use result::WebSocketError;
2626

27-
// TODO: IMPORTANT: check if frame_size is correct,
28-
// do not call .reserve with the entire size
29-
3027
/// Even though a websocket connection may look perfectly symmetrical
3128
/// in reality there are small differences between clients and servers.
3229
/// This type is passed to the codecs to inform them of what role they are in
@@ -290,8 +287,6 @@ impl<M> Encoder for MessageCodec<M>
290287
}
291288
}
292289

293-
// TODO: add tests to check boundary cases for reading dataframes
294-
295290
#[cfg(test)]
296291
mod tests {
297292
use super::*;

src/dataframe.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@ impl DataFrame {
6161
if !should_be_masked {
6262
return Err(WebSocketError::DataFrameError("Expected unmasked data frame"));
6363
}
64-
// TODO: move data to avoid copy?
6564
mask::mask_data(mask, &body)
6665
}
6766
None => {

src/receiver.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,6 @@ impl ws::Receiver for Receiver {
132132
}
133133
}
134134

135-
Ok(::std::mem::replace(&mut self.buffer, Vec::new()))
135+
Ok(::std::mem::replace(&mut self.buffer, Vec::new()))
136136
}
137137
}

0 commit comments

Comments
 (0)