Skip to content

Commit b2daab0

Browse files
yimingjfeyimingjfe
authored
chore: add default test case when node version is less than 18 (#6822)
1 parent f8b5ea9 commit b2daab0

File tree

2 files changed

+172
-140
lines changed

2 files changed

+172
-140
lines changed

‎tests/integration/rsc-csr-app/tests/index.test.ts

Lines changed: 79 additions & 63 deletions
Original file line numberDiff line numberDiff line change
@@ -13,79 +13,95 @@ import {
1313

1414
const appDir = path.resolve(__dirname, '../');
1515

16-
if (isVersionAtLeast18()) {
17-
describe('dev', () => {
18-
let app: any;
19-
let appPort: number;
20-
let page: Page;
21-
let browser: Browser;
22-
beforeAll(async () => {
23-
appPort = await getPort();
24-
app = await launchApp(
25-
appDir,
26-
appPort,
27-
{},
28-
{
29-
BUNDLER: 'webpack',
30-
},
31-
);
32-
browser = await puppeteer.launch(launchOptions as any);
33-
page = await browser.newPage();
34-
});
16+
describe('dev', () => {
17+
let app: any;
18+
let appPort: number;
19+
let page: Page;
20+
let browser: Browser;
3521

36-
afterAll(async () => {
37-
await killApp(app);
38-
await page.close();
39-
await browser.close();
22+
if (!isVersionAtLeast18()) {
23+
test('should skip in lower node version', () => {
24+
expect(true).toBe(true);
4025
});
4126

42-
describe('csr and rsc', () => {
43-
const baseUrl = `/`;
44-
it('should render page correctly', () =>
45-
renderServerRootPageCorrectly({ baseUrl, appPort, page }));
46-
it('should support client and server actions', () =>
47-
supportServerAction({ baseUrl, appPort, page }));
48-
});
27+
return;
28+
}
29+
30+
beforeAll(async () => {
31+
appPort = await getPort();
32+
app = await launchApp(
33+
appDir,
34+
appPort,
35+
{},
36+
{
37+
BUNDLER: 'webpack',
38+
},
39+
);
40+
browser = await puppeteer.launch(launchOptions as any);
41+
page = await browser.newPage();
4942
});
5043

51-
describe('build', () => {
52-
let appPort: number;
53-
let app: unknown;
54-
let page: Page;
55-
let browser: Browser;
56-
const errors: string[] = [];
57-
beforeAll(async () => {
58-
appPort = await getPort();
59-
await modernBuild(appDir, [], {
60-
env: {
61-
BUNDLER: 'webpack',
62-
},
63-
});
64-
app = await modernServe(appDir, appPort, {
65-
cwd: appDir,
66-
});
67-
browser = await puppeteer.launch(launchOptions as any);
68-
page = await browser.newPage();
69-
page.on('pageerror', error => {
70-
errors.push(error.message);
71-
});
72-
});
44+
afterAll(async () => {
45+
await killApp(app);
46+
await page.close();
47+
await browser.close();
48+
});
49+
50+
describe('csr and rsc', () => {
51+
const baseUrl = `/`;
52+
it('should render page correctly', () =>
53+
renderServerRootPageCorrectly({ baseUrl, appPort, page }));
54+
it('should support client and server actions', () =>
55+
supportServerAction({ baseUrl, appPort, page }));
56+
});
57+
});
58+
59+
describe('build', () => {
60+
let appPort: number;
61+
let app: unknown;
62+
let page: Page;
63+
let browser: Browser;
64+
const errors: string[] = [];
7365

74-
afterAll(async () => {
75-
await killApp(app);
76-
await page.close();
77-
await browser.close();
66+
if (!isVersionAtLeast18()) {
67+
test('should skip in lower node version', () => {
68+
expect(true).toBe(true);
7869
});
7970

80-
describe('csr and rsc', () => {
81-
const baseUrl = `/`;
82-
it('should render page correctly', () =>
83-
renderServerRootPageCorrectly({ baseUrl, appPort, page }));
84-
it('should support server action', () =>
85-
supportServerAction({ baseUrl, appPort, page }));
71+
return;
72+
}
73+
74+
beforeAll(async () => {
75+
appPort = await getPort();
76+
await modernBuild(appDir, [], {
77+
env: {
78+
BUNDLER: 'webpack',
79+
},
80+
});
81+
app = await modernServe(appDir, appPort, {
82+
cwd: appDir,
83+
});
84+
browser = await puppeteer.launch(launchOptions as any);
85+
page = await browser.newPage();
86+
page.on('pageerror', error => {
87+
errors.push(error.message);
8688
});
8789
});
88-
}
90+
91+
afterAll(async () => {
92+
await killApp(app);
93+
await page.close();
94+
await browser.close();
95+
});
96+
97+
describe('csr and rsc', () => {
98+
const baseUrl = `/`;
99+
it('should render page correctly', () =>
100+
renderServerRootPageCorrectly({ baseUrl, appPort, page }));
101+
it('should support server action', () =>
102+
supportServerAction({ baseUrl, appPort, page }));
103+
});
104+
});
89105

90106
interface TestOptions {
91107
baseUrl: string;

‎tests/integration/rsc-ssr-app/tests/index.test.ts

Lines changed: 93 additions & 77 deletions
Original file line numberDiff line numberDiff line change
@@ -13,97 +13,113 @@ import {
1313

1414
const appDir = path.resolve(__dirname, '../');
1515

16-
if (isVersionAtLeast18()) {
17-
describe('dev', () => {
18-
let app: any;
19-
let appPort: number;
20-
let page: Page;
21-
let browser: Browser;
22-
beforeAll(async () => {
23-
appPort = await getPort();
24-
app = await launchApp(
25-
appDir,
26-
appPort,
27-
{},
28-
{
29-
BUNDLER: 'webpack',
30-
},
31-
);
32-
browser = await puppeteer.launch(launchOptions as any);
33-
page = await browser.newPage();
16+
describe('dev', () => {
17+
let app: any;
18+
let appPort: number;
19+
let page: Page;
20+
let browser: Browser;
21+
22+
if (!isVersionAtLeast18()) {
23+
test('should skip in lower node version', () => {
24+
expect(true).toBe(true);
3425
});
3526

36-
afterAll(async () => {
37-
await killApp(app);
38-
await page.close();
39-
await browser.close();
40-
});
27+
return;
28+
}
29+
30+
beforeAll(async () => {
31+
appPort = await getPort();
32+
app = await launchApp(
33+
appDir,
34+
appPort,
35+
{},
36+
{
37+
BUNDLER: 'webpack',
38+
},
39+
);
40+
browser = await puppeteer.launch(launchOptions as any);
41+
page = await browser.newPage();
42+
});
4143

42-
describe('client component root', () => {
43-
const baseUrl = `client-component-root`;
44+
afterAll(async () => {
45+
await killApp(app);
46+
await page.close();
47+
await browser.close();
48+
});
4449

45-
it('should render page correctly', () =>
46-
renderClientRootPageCorrectly({ baseUrl, appPort, page }));
47-
it('should render page with context correctly', () =>
48-
renderPageWithContext({ baseUrl, appPort, page }));
49-
});
50+
describe('client component root', () => {
51+
const baseUrl = `client-component-root`;
5052

51-
describe('server component root', () => {
52-
const baseUrl = `server-component-root`;
53-
it('should render page correctly', () =>
54-
renderServerRootPageCorrectly({ baseUrl, appPort, page }));
55-
it('should support client and server actions', () =>
56-
supportServerAction({ baseUrl, appPort, page }));
57-
});
53+
it('should render page correctly', () =>
54+
renderClientRootPageCorrectly({ baseUrl, appPort, page }));
55+
it('should render page with context correctly', () =>
56+
renderPageWithContext({ baseUrl, appPort, page }));
5857
});
5958

60-
describe('build', () => {
61-
let appPort: number;
62-
let app: unknown;
63-
let page: Page;
64-
let browser: Browser;
65-
const errors: string[] = [];
66-
beforeAll(async () => {
67-
appPort = await getPort();
68-
await modernBuild(appDir, [], {
69-
env: {
70-
BUNDLER: 'webpack',
71-
},
72-
});
73-
app = await modernServe(appDir, appPort, {
74-
cwd: appDir,
75-
});
76-
browser = await puppeteer.launch(launchOptions as any);
77-
page = await browser.newPage();
78-
page.on('pageerror', error => {
79-
errors.push(error.message);
80-
});
59+
describe('server component root', () => {
60+
const baseUrl = `server-component-root`;
61+
it('should render page correctly', () =>
62+
renderServerRootPageCorrectly({ baseUrl, appPort, page }));
63+
it('should support client and server actions', () =>
64+
supportServerAction({ baseUrl, appPort, page }));
65+
});
66+
});
67+
68+
describe('build', () => {
69+
let appPort: number;
70+
let app: unknown;
71+
let page: Page;
72+
let browser: Browser;
73+
const errors: string[] = [];
74+
75+
if (!isVersionAtLeast18()) {
76+
test('should skip in lower node version', () => {
77+
expect(true).toBe(true);
8178
});
8279

83-
afterAll(async () => {
84-
await killApp(app);
85-
await page.close();
86-
await browser.close();
80+
return;
81+
}
82+
83+
beforeAll(async () => {
84+
appPort = await getPort();
85+
await modernBuild(appDir, [], {
86+
env: {
87+
BUNDLER: 'webpack',
88+
},
89+
});
90+
app = await modernServe(appDir, appPort, {
91+
cwd: appDir,
8792
});
93+
browser = await puppeteer.launch(launchOptions as any);
94+
page = await browser.newPage();
95+
page.on('pageerror', error => {
96+
errors.push(error.message);
97+
});
98+
});
8899

89-
describe('client component root', () => {
90-
const baseUrl = `client-component-root`;
100+
afterAll(async () => {
101+
await killApp(app);
102+
await page.close();
103+
await browser.close();
104+
});
91105

92-
it('should render page correctly', () =>
93-
renderClientRootPageCorrectly({ baseUrl, appPort, page }));
94-
it('should render page with context correctly', () =>
95-
renderPageWithContext({ baseUrl, appPort, page }));
96-
});
106+
describe('client component root', () => {
107+
const baseUrl = `client-component-root`;
97108

98-
describe('server component root', () => {
99-
const baseUrl = `server-component-root`;
100-
it('should render page correctly', () =>
101-
renderServerRootPageCorrectly({ baseUrl, appPort, page }));
102-
it('should support server action', () =>
103-
supportServerAction({ baseUrl, appPort, page }));
104-
});
109+
it('should render page correctly', () =>
110+
renderClientRootPageCorrectly({ baseUrl, appPort, page }));
111+
it('should render page with context correctly', () =>
112+
renderPageWithContext({ baseUrl, appPort, page }));
105113
});
106-
}
114+
115+
describe('server component root', () => {
116+
const baseUrl = `server-component-root`;
117+
it('should render page correctly', () =>
118+
renderServerRootPageCorrectly({ baseUrl, appPort, page }));
119+
it('should support server action', () =>
120+
supportServerAction({ baseUrl, appPort, page }));
121+
});
122+
});
107123

108124
interface TestOptions {
109125
baseUrl: string;

0 commit comments

Comments
 (0)