Skip to content

Commit 3d0e770

Browse files
committed
Improve CMake builds.
1. Updated test target by utilizing CMAKE_RUNTIME_OUTPUT_DIRECTORY variable. 2. Updated cpack to pick up the LICENSE. 3. Added 'S' prefix for static libs. Patch provided by: Sergey Nikulov <snikulov at users dot sourceforge dot net>
1 parent 35601df commit 3d0e770

File tree

3 files changed

+9
-2
lines changed

3 files changed

+9
-2
lines changed

CMakeLists.txt

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,11 @@ option(WITH_ICONV "Use iconv() for char->wchar_t conversion."
4242

4343
set(_WIN32_WINNT 0x0500 CACHE STRING "Define Windows API version to use.")
4444

45+
if (NOT ${BUILD_SHARED_LIBS})
46+
# set S-prefix for static build
47+
set (log4cplus_postfix "${log4cplus_postfix}S")
48+
endif()
49+
4550
if (UNICODE)
4651
set (log4cplus_postfix "${log4cplus_postfix}U")
4752
endif (UNICODE)
@@ -63,6 +68,8 @@ include_directories (${log4cplus_SOURCE_DIR}/include
6368
${log4cplus_BINARY_DIR}/include
6469
)
6570

71+
set(CMAKE_RUNTIME_OUTPUT_DIRECTORY ${PROJECT_BINARY_DIR}/bin)
72+
6673
if (LOG4CPLUS_BUILD_TESTING)
6774
enable_testing()
6875
endif (LOG4CPLUS_BUILD_TESTING)

Log4CPlusCPack.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
set(CPACK_PACKAGE_NAME log4cplus)
22
set(CPACK_PACKAGE_VERSION "${log4cplus_version_major}.${log4cplus_version_minor}.${log4cplus_version_patch}")
33
set(CPACK_PACKAGE_DESCRIPTION_SUMMARY "log4cplus is a log4j-inspired logging library for C++")
4-
4+
set(CPACK_RESOURCE_FILE_LICENSE ${CMAKE_SOURCE_DIR}/LICENSE)
55
include(CPack)
66

tests/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ function(log4cplus_add_test _name)
1212
# message (STATUS "${_name} sources: ${_srcs}")
1313
add_executable (${_name} ${_srcs})
1414
target_link_libraries (${_name} ${log4cplus})
15-
add_test(${_name} ${_name})
15+
add_test(NAME ${_name} WORKING_DIRECTORY ${CMAKE_RUNTIME_OUTPUT_DIRECTORY} COMMAND ${_name})
1616
endfunction()
1717

1818

0 commit comments

Comments
 (0)