Merge branch 'master' into hotfix/v1.8.4

patzick · patzick · commit 1d15f1511fcd · 2019-03-25T14:56:03.000+01:00
diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md
@@ -1,28 +1,44 @@
 ---
 name: Bug report
 about: Create a report to help us improve
+labels: bug
 
 ---
 
 ## Current behavior
 <!--  Describe the current behavior pointing exactly why it's not working as intended. -->
 
+
+
 ## Expected behavior
 <!-- Describe what the desired behavior should be. -->
 
+
+
 ## Steps to reproduce the issue
 <!--
 Please provide the steps to reproduce and if possible a *minimal reproducible example* of the problem via
 https://stackblitz.com or with a screenshot if it's more accurate.
  -->
 
+
+
 ## Repository
 <!-- If possible, share a repository link where this problem occurs -->
 
+
+
 # Can you handle fixing this bug by yourself?
-<!-- 
-If you can handle fixing this bug by yourself and later propose a Pull Request with the solution please answer YES. otherwise answer NO.
--->
+
+- [ ] YES
+- [ ] NO
+
+# Which [Release Cycle](https://docs.vuestorefront.io/guide/basics/release-cycle.html) state this refers to? Info for developer.
+Pick one option.
+
+- [ ] This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from `develop` branch and create Pull Request `2. Feature / Improvement` back to `develop`.
+- [ ] This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from `release` branch and create Pull Request `3. Stabilisation fix` back to `release`.
+- [ ] This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from `hotfix` or `master` branch and create Pull Request `4. Hotfix` back to `hotfix`.
 
 ## Environment details
 <!-- Please provide all the informations required below. -->
@@ -33,3 +49,4 @@ If you can handle fixing this bug by yourself and later propose a Pull Request w
 
 ## Additional information
 <!-- If you think that any additional information would be useful, please provide them here. -->
+
diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md
@@ -8,15 +8,24 @@ about: Suggest an idea for this project
 <!-- Describe the motivation or the concrete use case for new feature or why one of current ones should be enhanced. -->
 
 
+
 ## What are the acceptance criteria 
 <!-- List the acceptance criteria for this task in a form of a list. -->
-- ...
-- ...
+
+- [ ] 
 
 # Can you complete this feature request by yourself?
-<!-- 
-If you can handle the development of this feature request and later propose a Pull Request with the solution please answer YES. otherwise answer NO.
--->
+
+- [ ] YES
+- [ ] NO
+
+# Which [Release Cycle](https://docs.vuestorefront.io/guide/basics/release-cycle.html) state this refers to? Info for developer.
+Pick one option.
+
+- [x] This is a normal feature request. This should be available on https://test.storefrontcloud.io and then after tests this can be added to next Vue Storefront version. In this case Developer should create branch from `develop` branch and create Pull Request `2. Feature / Improvement` back to `develop`.
+- [ ] (**Pick this option only if you're sure**) This is an important improvement request for current Release Candidate version on https://next.storefrontcloud.io and should be placed in next RC version. In this case Developer should create branch from `release` branch and create Pull Request `3. Stabilisation fix` back to `release`.
+- [ ] (**Pick this option only if you're sure**) This is a critical improvement request for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version. In this case Developer should create branch from `hotfix` or `master` branch and create Pull Request `4. Hotfix` back to `hotfix`.
 
 ## Additional information
 <!-- If you think that any additional information would be useful please provide them here. -->
+
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
diff --git a/.github/PULL_REQUEST_TEMPLATE/feature-improvement.md b/.github/PULL_REQUEST_TEMPLATE/feature-improvement.md
@@ -0,0 +1,34 @@
+---
+name: 2. Feature / Improvement
+about: New feature or some improvements to current develop version (https://test.storefrontcloud.io). This is for branches created from `develop` branch and should be merged back into `develop`.
+
+---
+
+This is a feature or improvement for current test version on https://test.storefrontcloud.io
+
+### Related issues
+<!--  Put related issue number. -->
+
+closes #
+
+### Short description and why it's useful
+<!-- describe in a few words what is this Pull Request changing and why it's useful -->
+
+
+
+### Screenshots of visual changes before/after (if there are any)
+<!-- if you made any changes in the UI layer please provide before/after screenshots -->
+
+
+
+### PR status check
+This is a feature or improvement PR for current test version. In case of any doubts please read about [Release Cycle](https://docs.vuestorefront.io/guide/basics/release-cycle.html)
+
+- [ ] I've created this branch from `develop` branch and want to merge it back to `develop`
+
+### Upgrade Notes and Changelog
+
+- [x] No upgrade steps required (100% backward compatibility and no breaking changes)
+- [ ] I've updated the [Upgrade notes](https://github.com/DivanteLtd/vue-storefront/blob/develop/doc/Upgrade%20notes.md) and [Changelog](https://github.com/DivanteLtd/vue-storefront/blob/develop/CHANGELOG.md) on how to port existing VS sites with this new feature
+
+**IMPORTANT NOTICE** - PR needs to have all checks to be merged in (except braking changes check).
diff --git a/.github/PULL_REQUEST_TEMPLATE/first-pr.md b/.github/PULL_REQUEST_TEMPLATE/first-pr.md
@@ -0,0 +1,42 @@
+---
+name: 1. First PR for Vue Storefront
+about: Is it your first PR for Vue Storefront and you're not sure what to pick? No worries, we got you covered! Pick this template.
+
+---
+
+This is my first PR for storefront or i'm not sure which other PR should i choose.
+<!-- If that's correct then just go along with this template. You can click 'preview' above to see how it will be shown at the end -->
+
+### Related issues
+<!--  Put related issue number which this PR is closing. For example #123 -->
+
+closes #
+
+### Short description and why it's useful
+<!-- describe in a few words what is this Pull Request changing and why it's useful -->
+
+
+
+### Screenshots of visual changes before/after (if there are any)
+<!-- if you made any changes in the UI layer please provide before/after screenshots -->
+
+### Which environment this relates to
+Check your case. In case of any doubts please read about [Release Cycle](https://docs.vuestorefront.io/guide/basics/release-cycle.html)
+
+- [ ] Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from `develop` branch and want to merge it back to `develop`
+- [ ] RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from `release` branch and want to merge it back to `release`
+- [ ] Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from `hotfix` or `master` branch and want to merge it back to `hotfix`
+
+### Upgrade Notes and Changelog
+
+- [x] No upgrade steps required (100% backward compatibility and no breaking changes)
+- [ ] I've updated the [Upgrade notes](https://github.com/DivanteLtd/vue-storefront/blob/develop/doc/Upgrade%20notes.md) and [Changelog](https://github.com/DivanteLtd/vue-storefront/blob/develop/CHANGELOG.md) on how to port existing VS sites with this new feature
+
+**IMPORTANT NOTICE** - Remember to update `CHANGELOG.md` with description of your change
+
+### Contribution and currently important rules acceptance
+<!-- Please get familiar with following info -->
+
+- [ ] I read and followed [contribution rules](https://github.com/DivanteLtd/vue-storefront/blob/master/CONTRIBUTING.md)
+- [ ] I read the [TypeScript Action Plan](https://github.com/DivanteLtd/vue-storefront/blob/master/doc/TypeScript%20Action%20Plan.md) and adjusted my PR according to it
+- [ ] I read about [Vue Storefront Modules](https://github.com/DivanteLtd/vue-storefront/blob/master/doc/api-modules/about-modules.md) and I am aware that every new feature should be a module
diff --git a/.github/PULL_REQUEST_TEMPLATE/hotfix.md b/.github/PULL_REQUEST_TEMPLATE/hotfix.md
@@ -0,0 +1,35 @@
+---
+name: 4. Hotfix
+about: Bugfix for current stable version (https://demo.storefrontcloud.io). This is for branches created from `hotfix` or `master` branch and should be merged back into `hotfix`.
+
+---
+
+This is a bugfix for current stable version on https://demo.storefrontcloud.io
+
+### Related issues
+<!--  Put related issue number. -->
+
+closes #
+
+### Short description and why it's useful
+<!-- describe in a few words what is this Pull Request changing and why it's useful -->
+
+
+
+### Screenshots of visual changes before/after (if there are any)
+<!-- if you made any changes in the UI layer please provide before/after screenshots -->
+
+
+
+### PR status check
+This is hotfix PR, it means that it contain fix for current stable version. In case of any doubts please read about [Release Cycle](https://docs.vuestorefront.io/guide/basics/release-cycle.html)
+
+- [ ] I've created this branch from `master` or `hotfix` branch
+- [ ] I want to merge this PR into `hotfix` branch
+
+### Upgrade Notes and Changelog
+
+- [x] No upgrade steps required (100% backward compatibility and no breaking changes)
+- [ ] I've updated the [Upgrade notes](https://github.com/DivanteLtd/vue-storefront/blob/develop/doc/Upgrade%20notes.md) and [Changelog](https://github.com/DivanteLtd/vue-storefront/blob/develop/CHANGELOG.md) on how to port existing VS sites with this new feature
+
+**IMPORTANT NOTICE** - PR needs to have all checks to be merged in.
diff --git a/.github/PULL_REQUEST_TEMPLATE/stabilisation-fix.md b/.github/PULL_REQUEST_TEMPLATE/stabilisation-fix.md
@@ -0,0 +1,35 @@
+---
+name: 3. Stabilisation fix
+about: Fix for current Release Candidate version (https://next.storefrontcloud.io). This is for branches created from `release` branch and should be merged back into `release`.
+
+---
+
+This is a stabilisation fix for current Release Candidate version on https://next.storefrontcloud.io
+
+### Related issues
+<!--  Put related issue number. -->
+
+closes #
+
+### Short description and why it's useful
+<!-- describe in a few words what is this Pull Request changing and why it's useful -->
+
+
+
+### Screenshots of visual changes before/after (if there are any)
+<!-- if you made any changes in the UI layer please provide before/after screenshots -->
+
+
+
+### PR status check
+This is Release Candidate stabilisation PR, it means that it contain fix for current RC version. In case of any doubts please read about [Release Cycle](https://docs.vuestorefront.io/guide/basics/release-cycle.html)
+
+- [ ] I've created this branch from `release` branch
+- [ ] I want to merge this PR into `release` branch
+
+### Upgrade Notes and Changelog
+
+- [x] No upgrade steps required (100% backward compatibility and no breaking changes)
+- [ ] I've updated the [Upgrade notes](https://github.com/DivanteLtd/vue-storefront/blob/develop/doc/Upgrade%20notes.md) and [Changelog](https://github.com/DivanteLtd/vue-storefront/blob/develop/CHANGELOG.md) on how to port existing VS sites with this new feature
+
+**IMPORTANT NOTICE** - PR needs to have all checks to be merged in.
