Skip to content

[Bug]: test_vllm_port.py::test_get_vllm_port_uri fails with AssertionError: Regex pattern did not match #18617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
1 task done
rabi opened this issue May 23, 2025 · 0 comments · May be fixed by #18618
Open
1 task done

[Bug]: test_vllm_port.py::test_get_vllm_port_uri fails with AssertionError: Regex pattern did not match #18617

rabi opened this issue May 23, 2025 · 0 comments · May be fixed by #18618
Labels
bug Something isn't working

Comments

@rabi
Copy link
Contributor

rabi commented May 23, 2025

Your current environment

Issue seems to have been introduced in #18209

🐛 Describe the bug

Test fails with below traceback.

    def test_get_vllm_port_uri():
        """Test when VLLM_PORT is set to a URI."""
        with (patch.dict(os.environ, {"VLLM_PORT": "tcp://localhost:5678"},
                         clear=True),
>             pytest.raises(ValueError, match="appears to be a URI")):
E             AssertionError: Regex pattern did not match.
E              Regex: 'appears to be a URI'
E              Input: "VLLM_PORT 'tcp://localhost:5678' must be a valid integer"

tests/test_vllm_port.py:34: AssertionError

Before submitting a new issue...

  • Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.
@rabi rabi added the bug Something isn't working label May 23, 2025
rabi added a commit to rabi/vllm that referenced this issue May 23, 2025
@rabi
[Bugfix][Failing Test] Fix test_vllm_port.py
22c4cdf 
The urllib.parse.urlparse() function itself does not raise
an exception during the parsing of a URL. However, certain
attributes of the returned ParseResult object (e.g., .port)
may raise a ValueError when accessed if they contain invalid
values.

Issue introduced in vllm-project#18209

FIX: vllm-project#18617
Signed-off-by: rabi <[email protected]>
@rabi rabi linked a pull request May 23, 2025 that will close this issue
Open
rabi added a commit to rabi/vllm that referenced this issue May 23, 2025
@rabi
[Bugfix][Failing Test] Fix test_vllm_port.py
c52bb5c 
The urllib.parse.urlparse() function itself does not raise
an exception during the parsing of a URL. However, certain
attributes of the returned ParseResult object (e.g., .port)
may raise a ValueError when accessed if they contain invalid
values.

Issue introduced in vllm-project#18209

FIX: vllm-project#18617
Signed-off-by: rabi <[email protected]>
rabi added a commit to rabi/vllm that referenced this issue May 23, 2025
@rabi
[Bugfix][Failing Test] Fix test_vllm_port.py
b5df503 
The urllib.parse.urlparse() function itself does not raise
an exception during the parsing of a URL. However, certain
attributes of the returned ParseResult object (e.g., .port)
may raise a ValueError when accessed if they contain invalid
values.

Issue introduced in vllm-project#18209

FIX: vllm-project#18617
Signed-off-by: rabi <[email protected]>
rabi added a commit to rabi/vllm that referenced this issue May 23, 2025
@rabi
[Bugfix][Failing Test] Fix test_vllm_port.py
95d88d1 
The urllib.parse.urlparse() function itself does not raise
an exception during the parsing of a URL. However, certain
attributes of the returned ParseResult object (e.g., .port)
may raise a ValueError when accessed if they contain invalid
values.

Issue introduced in vllm-project#18209

FIX: vllm-project#18617
Signed-off-by: rabi <[email protected]>
rabi added a commit to rabi/vllm that referenced this issue May 26, 2025
@rabi
[Bugfix][Failing Test] Fix test_vllm_port.py
1ad957c 
The urllib.parse.urlparse() function itself does not raise
an exception during the parsing of a URL. However, certain
attributes of the returned ParseResult object (e.g., .port)
may raise a ValueError when accessed if they contain invalid
values.

Issue introduced in vllm-project#18209

FIX: vllm-project#18617
Signed-off-by: rabi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Bugfix][Failing Test] Fix test_vllm_port.py rabi/vllm
1 participant
@rabi