Should we be using expect.fail or assert.fail?

[KirillTregubov]

The docs have an entry for assert.fail but not for expect.fail.

It seems that both of these definitions come from @types/chai and have similar behaviours (in the limited testing I have conducted). However, assert.fail also has a nicer docstring that says it's Node.js assert module-compatible.

My main questions are:

1. Is there a functional difference between the two?
2. Should we document expect.fail if it provides the same functionality, as most of the tests I have written don't use assert (so it might help reduce imports)

[sheremet-va]

We should probably document chai's API. For now, we only document Jest-style API.

Functionally, assert.fail and expect.fail are identical, they just throw an error.

[KirillTregubov]

Is vitest's long-term goal (or current reality?) to support both API surfaces? How far along is the compatbility?

I would be willing to open a PR if you can point me in the right direction.

[sheremet-va]

Vitest uses chai since the first commit, all Jest-style assertions are built on top of it.

I would be willing to open a PR if you can point me in the right direction.

I don't really know the best way to present it, it's just "nice to have".

[KirillTregubov]

I see, thanks for the fast responses.

Happy Holidays!