Skip to content

Bug Report: MySQL Shell backup engine fails to restore with --mysql-shell-speedup-restore=true #18309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rvrangel opened this issue May 29, 2025 · 0 comments · May be fixed by #18310
Open

Bug Report: MySQL Shell backup engine fails to restore with --mysql-shell-speedup-restore=true #18309

rvrangel opened this issue May 29, 2025 · 0 comments · May be fixed by #18310
Labels
Component: Backup and Restore Type: Bug

Comments

@rvrangel
Copy link
Contributor

Overview of the Issue

It seems when we enable the flag above, we need to check server capabilities to make sure we can run ALTER INSTANCE DISABLE INNODB REDO_LOG, but the validation fails because the version string is not being parsed properly before.

The expected version should be major.minor.patch but we are getting something like Ver 8.#.## Percona Server (GPL), Release '##', Revision '######' which breaks the validation.

Reproduction Steps

try to take a mysqlshell backup and the restore it in a tablet that is using --mysql-shell-speedup-restore=true

Binary Version

vttablet version Version: 23.0.0-SNAPSHOT (Git revision cec7812fc597817dead7c92987db3bc918e10605 branch 'master') built on Thu May 29 09:10:46 PDT 2025 by #### using go1.24.3 linux/amd64

Operating System and Environment details

N/A

Log Fragments

I0529 05:30:24.188580   32687 backup.go:433] Restore: RestorePath: [full:2025-05-29.120513.us_east_1d-0171548866]
I0529 05:30:24.188616   32687 mysqlshellbackupengine.go:248] Calling ExecuteRestore for vt_###### (DeleteBeforeRestore: false)
I0529 05:30:24.189058   32687 restore.go:283] Restore: got a restore manifest: <nil>, err=MySQLShellPreCheckError: MySQL version doesn't support disabling the redo log (must be >=8.0.21)
failed restore precheck, waitForBackupInterval=0s
@rvrangel rvrangel added Type: Bug Needs Triage This issue needs to be correctly labelled and triaged labels May 29, 2025
@rvrangel rvrangel linked a pull request May 30, 2025 that will close this issue
Open
5 tasks
@deepthi deepthi added Component: Backup and Restore and removed Needs Triage This issue needs to be correctly labelled and triaged labels Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Backup and Restore Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix version issue when using --mysql-shell-speedup-restore=true rvrangel/vitess
2 participants
@deepthi @rvrangel