Skip to content

Commit 54a782f

Browse files
authored
test(react-swc): simplify ts-lib test (#548)
1 parent b37d377 commit 54a782f

File tree

14 files changed

+57
-147
lines changed

14 files changed

+57
-147
lines changed

.github/renovate.json5

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,6 @@
3636
// manually bumping
3737
"node",
3838

39-
"generouted", // testing lib shipping JSX (new version ship transpiled JS)
40-
4139
// breaking changes
4240
"source-map", // `source-map:v0.7.0+` needs more investigation
4341
"kill-port", // `kill-port:^2.0.0 has perf issues (#8392)

package.json

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -70,15 +70,5 @@
7070
"playground/**/__tests__/**/*.ts": [
7171
"eslint --cache --fix"
7272
]
73-
},
74-
"pnpm": {
75-
"packageExtensions": {
76-
"generouted": {
77-
"peerDependencies": {
78-
"react": "*",
79-
"react-router-dom": "*"
80-
}
81-
}
82-
}
8373
}
8474
}
Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,22 @@
1-
import { expect, test } from '@playwright/test'
1+
import { type Page, expect, test } from '@playwright/test'
22
import { setupBuildAndPreview, setupDevServer } from '../../utils.ts'
33

44
test('TS lib build', async ({ page }) => {
55
const { testUrl, server } = await setupBuildAndPreview('ts-lib')
66
await page.goto(testUrl)
7-
await expect(page.locator('main')).toHaveText('Home page')
8-
9-
await page.locator('a', { hasText: 'About' }).click()
10-
await expect(page.locator('main')).toHaveText('About page')
11-
7+
await testNonJs(page)
128
await server.httpServer.close()
139
})
1410

1511
test('TS lib dev', async ({ page }) => {
1612
const { testUrl, server } = await setupDevServer('ts-lib')
1713
await page.goto(testUrl)
18-
await expect(page.locator('main')).toHaveText('Home page')
19-
20-
await page.locator('a', { hasText: 'About' }).click()
21-
await expect(page.locator('main')).toHaveText('About page')
22-
14+
await testNonJs(page)
2315
await server.close()
2416
})
17+
18+
async function testNonJs(page: Page) {
19+
await expect(page.getByTestId('test-non-js')).toHaveText('test-non-js: 0')
20+
await page.getByTestId('test-non-js').click()
21+
await expect(page.getByTestId('test-non-js')).toHaveText('test-non-js: 1')
22+
}

packages/plugin-react-swc/playground/ts-lib/package.json

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,9 @@
88
"preview": "vite preview"
99
},
1010
"dependencies": {
11-
"@generouted/react-router": "^1.20.0",
12-
"generouted": "1.11.7",
11+
"@vitejs/test-dep-non-js": "file:./test-dep/non-js",
1312
"react": "^19.1.0",
14-
"react-dom": "^19.1.0",
15-
"react-router-dom": "^7.6.3"
13+
"react-dom": "^19.1.0"
1614
},
1715
"devDependencies": {
1816
"@types/react": "^19.1.8",
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
import TestNonJs from '@vitejs/test-dep-non-js'
2+
3+
export default function App() {
4+
return (
5+
<section style={{ margin: 24 }}>
6+
<main>
7+
<TestNonJs />
8+
</main>
9+
</section>
10+
)
11+
}
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
import { StrictMode } from 'react'
22
import { createRoot } from 'react-dom/client'
3-
import { Routes } from 'generouted/react-router'
3+
import App from './app'
44

55
createRoot(document.getElementById('root')!).render(
66
<StrictMode>
7-
<Routes />
7+
<App />
88
</StrictMode>,
99
)

packages/plugin-react-swc/playground/ts-lib/src/pages/404.tsx

Lines changed: 0 additions & 3 deletions
This file was deleted.

packages/plugin-react-swc/playground/ts-lib/src/pages/_app.tsx

Lines changed: 0 additions & 16 deletions
This file was deleted.

packages/plugin-react-swc/playground/ts-lib/src/pages/about.tsx

Lines changed: 0 additions & 3 deletions
This file was deleted.

packages/plugin-react-swc/playground/ts-lib/src/pages/index.tsx

Lines changed: 0 additions & 10 deletions
This file was deleted.

0 commit comments

Comments
 (0)