[lib][arch] pass set funcitons params by reference

Author: amin1377

libs/libarchfpga/src/arch_util.cpp

@@ -700,7 +700,10 @@ void ProcessMemoryClass(t_pb_type* mem_pb_type) {
     mem_pb_type->model_id = LogicalModelId::INVALID();
 
     mem_pb_type->modes[0].num_interconnect = mem_pb_type->num_ports * num_pb;
-    VTR_ASSERT(mem_pb_type->modes[0].num_interconnect > 0);
+    
+    std::stringstream ss;
+    ss << "Memory pb_type " << mem_pb_type->name << " has no interconnect";
+    VTR_ASSERT_MSG(mem_pb_type->modes[0].num_interconnect > 0, ss.str().c_str());
     mem_pb_type->modes[0].interconnect = new t_interconnect[mem_pb_type->modes[0].num_interconnect];
 
     for (i = 0; i < mem_pb_type->modes[0].num_interconnect; i++) {

libs/libarchfpga/src/physical_types.h

@@ -2293,14 +2293,34 @@ struct t_arch {
     char* architecture_id;
 
     // Options for tileable routing architectures
+
+    /// Whether the routing architecture is tileable
     bool tileable;
+
+    /// Allow connection blocks to appear around the perimeter programmable block
     bool perimeter_cb;
+
+    /// Remove all the routing wires in empty regions
     bool shrink_boundary;
+
+    /// Allow routing channels to pass through multi-width and 
+    /// multi-height programable blocks
     bool through_channel;
+
+    /// Allow each output pin of a programmable block to drive the 
+    /// routing tracks on all the sides of its adjacent switch block
     bool opin2all_sides;
+
+    /// Whether the routing architecture has concat wire
+    /// For further detail, please refer to documentation
     bool concat_wire;
+
+    /// Whether the routing architecture has concat pass wire
+    /// For further detail, please refer to documentation
     bool concat_pass_wire;
 
+    // End of tileable architecture options
+
     t_chan_width_dist Chans;
     enum e_switch_block_type SBType;
     enum e_switch_block_type SBSubType;

libs/libarchfpga/src/vib_inf.cpp

@@ -1,9 +1,4 @@
 #include "vib_inf.h"
-// #include "vtr_math.h"
-// #include "vtr_util.h"
-// #include "vtr_log.h"
-
-// #include "arch_util.h"
 
 VibInf::VibInf() {
     name_.clear();
@@ -15,12 +10,12 @@ VibInf::VibInf() {
     second_stages_.clear();
 }
 
-void VibInf::set_name(const std::string name) {
+void VibInf::set_name(const std::string& name) {
     VTR_ASSERT(!name.empty());
     name_ = name;
 }
 
-void VibInf::set_pbtype_name(const std::string pbtype_name) {
+void VibInf::set_pbtype_name(const std::string& pbtype_name) {
     VTR_ASSERT(!pbtype_name.empty());
     pbtype_name_ = pbtype_name;
 }
@@ -35,46 +30,37 @@ void VibInf::set_switch_idx(const int switch_idx) {
     switch_idx_ = switch_idx;
 }
 
-void VibInf::set_switch_name(const std::string switch_name) {
+void VibInf::set_switch_name(const std::string& switch_name) {
     VTR_ASSERT(!switch_name.empty());
     switch_name_ = switch_name;
 }
 
-void VibInf::set_seg_groups(const std::vector<t_seg_group> seg_groups) {
+void VibInf::set_seg_groups(const std::vector<t_seg_group>& seg_groups) {
     VTR_ASSERT(!seg_groups.empty());
-    seg_groups_.clear();
-    for (auto seg_group : seg_groups) {
-        seg_groups_.push_back(seg_group);
-    }
+    seg_groups_ = seg_groups;
 }
 
-void VibInf::push_seg_group(const t_seg_group seg_group) {
+void VibInf::push_seg_group(const t_seg_group& seg_group) {
     VTR_ASSERT(!seg_group.name.empty());
     seg_groups_.push_back(seg_group);
 }
 
-void VibInf::set_first_stages(const std::vector<t_first_stage_mux_inf> first_stages) {
+void VibInf::set_first_stages(const std::vector<t_first_stage_mux_inf>& first_stages) {
     VTR_ASSERT(!first_stages.empty());
-    first_stages_.clear();
-    for (auto first_stage : first_stages) {
-        first_stages_.push_back(first_stage);
-    }
+    first_stages_ = first_stages;
 }
 
-void VibInf::push_first_stage(const t_first_stage_mux_inf first_stage) {
+void VibInf::push_first_stage(const t_first_stage_mux_inf& first_stage) {
     VTR_ASSERT(!first_stage.mux_name.empty());
     first_stages_.push_back(first_stage);
 }
 
-void VibInf::set_second_stages(const std::vector<t_second_stage_mux_inf> second_stages) {
+void VibInf::set_second_stages(const std::vector<t_second_stage_mux_inf>& second_stages) {
     VTR_ASSERT(!second_stages.empty());
-    second_stages_.clear();
-    for (auto second_stage : second_stages) {
-        second_stages_.push_back(second_stage);
-    }
+    second_stages_ = second_stages;
 }
 
-void VibInf::push_second_stage(const t_second_stage_mux_inf second_stage) {
+void VibInf::push_second_stage(const t_second_stage_mux_inf& second_stage) {
     VTR_ASSERT(!second_stage.mux_name.empty());
     second_stages_.push_back(second_stage);
 }

libs/libarchfpga/src/vib_inf.h

@@ -121,17 +121,17 @@ class VibInf {
     VibInf();
 
   public:
-    void set_name(const std::string name);
-    void set_pbtype_name(const std::string pbtype_name);
+    void set_name(const std::string& name);
+    void set_pbtype_name(const std::string& pbtype_name);
     void set_seg_group_num(const int seg_group_num);
     void set_switch_idx(const int switch_idx);
-    void set_switch_name(const std::string switch_name);
-    void set_seg_groups(const std::vector<t_seg_group> seg_groups);
-    void push_seg_group(const t_seg_group seg_group);
-    void set_first_stages(const std::vector<t_first_stage_mux_inf> first_stages);
-    void push_first_stage(const t_first_stage_mux_inf first_stage);
-    void set_second_stages(const std::vector<t_second_stage_mux_inf> second_stages);
-    void push_second_stage(const t_second_stage_mux_inf second_stage);
+    void set_switch_name(const std::string& switch_name);
+    void set_seg_groups(const std::vector<t_seg_group>& seg_groups);
+    void push_seg_group(const t_seg_group& seg_group);
+    void set_first_stages(const std::vector<t_first_stage_mux_inf>& first_stages);
+    void push_first_stage(const t_first_stage_mux_inf& first_stage);
+    void set_second_stages(const std::vector<t_second_stage_mux_inf>& second_stages);
+    void push_second_stage(const t_second_stage_mux_inf& second_stage);
 
     std::string get_name() const;
     std::string get_pbtype_name() const;