apply review comments

Author: amin1377

vpr/src/base/SetupVPR.cpp

@@ -899,11 +899,11 @@ static void add_logical_pin_to_physical_tile(int physical_pin_offset,
                                              t_logical_block_type_ptr logical_block_ptr,
                                              t_physical_tile_type* physical_type) {
     for (auto logical_pin_pair : logical_block_ptr->pin_logical_num_to_pb_pin_mapping) {
-        auto pin_logical_num = logical_pin_pair.first;
-        auto pb_pin = logical_pin_pair.second;
+        int pin_logical_num = logical_pin_pair.first;
+        t_pb_graph_pin* pb_pin = logical_pin_pair.second;
         int pin_physical_num = pin_logical_num + physical_pin_offset;
-        physical_type->pin_num_to_pb_pin.insert(std::make_pair(pin_physical_num, pb_pin));
-        physical_type->pb_pin_to_pin_num.insert(std::make_pair(pb_pin, pin_physical_num));
+        physical_type->pin_num_to_pb_pin.insert({pin_physical_num, pb_pin});
+        physical_type->pb_pin_to_pin_num.insert({pb_pin, pin_physical_num});
     }
 }
 

vpr/src/util/vpr_utils.cpp

@@ -1720,7 +1720,7 @@ RRNodeId get_class_rr_node_id(const RRSpatialLookup& rr_spatial_lookup,
     return rr_spatial_lookup.find_node(layer, i, j, node_type, class_physical_num);
 }
 
-RRNodeId get_atom_pin_rr_node_id(const AtomPinId& atom_pin_id) {
+RRNodeId get_atom_pin_rr_node_id(AtomPinId atom_pin_id) {
     auto& atom_nlist = g_vpr_ctx.atom().netlist();
     auto& atom_lookup = g_vpr_ctx.atom().lookup();
     auto& place_ctx = g_vpr_ctx.placement();
@@ -1745,12 +1745,12 @@ RRNodeId get_atom_pin_rr_node_id(const AtomPinId& atom_pin_id) {
     const t_pb_graph_pin* atom_pb_pin = atom_lookup.atom_pin_pb_graph_pin(atom_pin_id);
     int pin_physical_num = physical_tile->pb_pin_to_pin_num.at(atom_pb_pin);
 
-    auto rr_node_id = get_pin_rr_node_id(device_ctx.rr_graph.node_lookup(),
-                                         physical_tile,
-                                         clb_blk_loc.layer,
-                                         clb_blk_loc.x,
-                                         clb_blk_loc.y,
-                                         pin_physical_num);
+    RRNodeId rr_node_id = get_pin_rr_node_id(device_ctx.rr_graph.node_lookup(),
+                                             physical_tile,
+                                             clb_blk_loc.layer,
+                                             clb_blk_loc.x,
+                                             clb_blk_loc.y,
+                                             pin_physical_num);
 
     return rr_node_id;
 }

vpr/src/util/vpr_utils.h

@@ -254,7 +254,7 @@ RRNodeId get_pin_rr_node_id(const RRSpatialLookup& rr_spatial_lookup,
  * since, otherwise, the routing resources inside clusters are not added to the RR graph.
  * @param atom_pin_id The atom pin ID.
  */
-RRNodeId get_atom_pin_rr_node_id(const AtomPinId& atom_pin_id);
+RRNodeId get_atom_pin_rr_node_id(AtomPinId atom_pin_id);
 
 RRNodeId get_class_rr_node_id(const RRSpatialLookup& rr_spatial_lookup,
                               t_physical_tile_type_ptr physical_tile,