undid a couple changes to fix odin memory leak

Author: SamuelHo10

libs/libarchfpga/src/arch_util.cpp

@@ -367,7 +367,7 @@ static void free_pb_type(t_pb_type* pb_type) {
         }
     }
     if (pb_type->num_annotations > 0) {
-        delete[] pb_type->annotations;
+        vtr::free(pb_type->annotations);
     }
 
     if (pb_type->pb_type_power) {
@@ -525,7 +525,7 @@ void alloc_and_load_default_child_for_pb_type(t_pb_type* pb_type,
         }
     }
 
-    copy->annotations = new t_pin_to_pin_annotation[pb_type->num_annotations]();
+    copy->annotations = (t_pin_to_pin_annotation*)vtr::calloc(pb_type->num_annotations, sizeof(t_pin_to_pin_annotation));
     copy->num_annotations = pb_type->num_annotations;
     for (i = 0; i < copy->num_annotations; i++) {
         copy->annotations[i].clock = vtr::strdup(pb_type->annotations[i].clock);
@@ -659,7 +659,7 @@ void ProcessLutClass(t_pb_type* lut_pb_type) {
         }
     }
     lut_pb_type->num_annotations = 0;
-    delete[] lut_pb_type->annotations;
+    vtr::free(lut_pb_type->annotations);
     lut_pb_type->annotations = nullptr;
     lut_pb_type->modes[1].pb_type_children[0].depth = lut_pb_type->depth + 1;
     lut_pb_type->modes[1].pb_type_children[0].parent_mode = &lut_pb_type->modes[1];

libs/libarchfpga/src/read_xml_arch_file.cpp

@@ -1375,7 +1375,7 @@ static void ProcessPb_Type(pugi::xml_node Parent,
             num_annotations += count_children(Parent, child_name, loc_data, ReqOpt::OPTIONAL);
         }
 
-        pb_type->annotations = new t_pin_to_pin_annotation[num_annotations]();
+        pb_type->annotations = (t_pin_to_pin_annotation*)vtr::calloc(num_annotations, sizeof(t_pin_to_pin_annotation));
         pb_type->num_annotations = num_annotations;
 
         int annotation_idx = 0;