Skip to content

@microsoft/microsoft-graph-client should be a dependency, not devDependency #112

@hkbertoson

Description

@hkbertoson

Bug Description

Problem:
@microsoft/microsoft-graph-client is listed in devDependencies but is imported at runtime in src/index.ts:

import {
  TokenCredentialAuthenticationProvider,
  type TokenCredentialAuthenticationProviderOptions,
} from "@microsoft/microsoft-graph-client/authProviders/azureTokenCredentials";

Since it's a devDependency, it won't be installed when consumers npm install @chat-adapter/teams. It only works currently because botbuilder happens to bring it in transitively.
Fix:
Move @microsoft/microsoft-graph-client from devDependencies to dependencies in package.json.

Steps to Reproduce

N/A

Expected Behavior

N/A

Actual Behavior

N/A

Code Sample

Chat SDK Version

Latest

Node.js Version

No response

Platform Adapter

Microsoft Teams

Operating System

macOS

Additional Context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions