Problems with generated types

[denerFernandes]

Hi guys, I'm working on a plugin for cms, I'm using the products as a reference, but I'm having problems with the types, they don't match.

I check this: #974 I think I'm doing the same as described by @michaelbromley

I use the last versions and i didn't forget to generate the types. I've been doing this for a while, can you help me?

My entities

Page entity

@Entity('page')
export class PageEntity
    extends VendureEntity
    implements Translatable, HasCustomFields, ChannelAware, SoftDeletable {
    constructor(input?: DeepPartial<PageEntity>) {
        super(input);
    }

    @Column({ type: Date, nullable: true })
    deletedAt: Date | null;

    name: LocaleString;

    slug: LocaleString;

    description: LocaleString;

    @Column({ default: true })
    enabled: boolean;

    @ManyToOne(type => Asset, { onDelete: 'SET NULL' })
    featuredAsset: Asset;

    @OneToMany(type => PageAssetEntity, pageAsset => pageAsset.page)
    assets: PageAssetEntity[];

    @OneToMany(type => PageTranslationEntity, translation => translation.base, { eager: true })
    translations: Array<Translation<PageEntity>>;

    @Column(type => CustomPageFieldsEntity)
    customFields: CustomPageFieldsEntity;

    @ManyToMany(type => Channel)
    @JoinTable()
    channels: Channel[];
}

Page translation entity

@Entity('page_translation')
export class PageTranslationEntity extends VendureEntity implements Translation<PageEntity>, HasCustomFields {
    constructor(input?: DeepPartial<Translation<PageEntity>>) {
        super(input);
    }

    @Column('varchar') languageCode: LanguageCode;

    @Column() name: string;

    @Column() slug: string;

    @Column('text') description: string;

    @ManyToOne(type => PageEntity, base => base.translations)
    base: PageEntity;

    @Column(type => CustomPageFieldsTranslationEntity)
    customFields: CustomPageFieldsTranslationEntity;
}

Graphql type

    type PageTranslation {
        id: ID
        createdAt: DateTime!
        updatedAt: DateTime!
        languageCode: LanguageCode!
        name: String!
        slug: String!
        description: String!
      }
      
      type Page implements Node {
        id: ID!
        createdAt: DateTime!
        updatedAt: DateTime!
        name: String!
        slug: String!
        description: String!
        translations: [PageTranslation!]!
      }

    type PageList implements PaginatedList {
        items: [Page!]!
        totalItems: Int!
    }

    extend type Query {
        pages(options: PageListOptions): PageList!
        page(id: ID!): Page
    }

    # Auto-generated at runtime
    input PageListOptions


    extend type Mutation {
        "Create a new Page"
        createPage(input: CreatePageInput!): Page!
        updatePage(input: UpdatePageInput!): Page!
    }

    input PageTranslationInput {
        id: ID
        languageCode: LanguageCode!
        name: String
        slug: String
        description: String
    }

    input CreatePageInput {
        featuredAssetId: ID
        enabled: Boolean
        assetIds: [ID!]
        translations: [PageTranslationInput]
    }

    input UpdatePageInput {
        id: ID!
        featuredAssetId: ID
        enabled: Boolean
        assetIds: [ID!]
        translations: [PageTranslationInput!]
    }
`

My resolver
```js
 @Transaction()
    @Mutation()
    @Allow(Permission.SuperAdmin)
    async createPage(
        @Ctx() ctx: RequestContext,
        @Args() args: MutationCreatePageArgs,
    ): Promise<Translated<PageEntity>> {
        const { input } = args;
        return this.pageService.create(ctx, input);
    }

My service

 async create(ctx: RequestContext, input: CreatePageInput): Promise<any> {

        await this.slugValidator.validateSlugs(ctx, input, PageTranslationEntity);
        const page = await this.translatableSaver.create({
            ctx,
            input,
            entityType: PageEntity,
            translationType: PageTranslationEntity,
            beforeSave: async p => {
                await this.channelService.assignToCurrentChannel(p, ctx);
                await this.assetService.updateFeaturedAsset(ctx, p, input);
            },
        });
        await this.customFieldRelationService.updateRelations(ctx, PageEntity, input, page);
        await this.assetService.updateEntityAssets(ctx, page, input);
        return assertFound(this.findOne(ctx, page.id));
    }

But i have this erros:

[michaelbromley]

Hi,

My first guess - try making your translations input array non-nullable:

translations: [PageTranslationInput!]!

[denerFernandes]

Thanks @michaelbromley

Don't work, i have the same problem.

[denerFernandes]

@michaelbromley i found the problem:

LanguageCode from core:

LanguageCode from my generated types:

In core is lowercase, in my generated types is camel case.

Solution was, add option namingConvention for keep enum in my codegen.json:
"config": { "strict": true, "namingConvention": { "enumValues": "keep" } },

[michaelbromley]

Oh glad to hear you got it sorted out!