Skip to content

Commit a2057de

Browse files
authored
fix(dashboard): Copy requiresPermission to nav menu items (#3938)
1 parent b27a985 commit a2057de

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

packages/dashboard/src/lib/framework/extension-api/logic/navigation.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,9 @@ export function registerNavigationExtensions(
2626
id: route.navMenuItem.id ?? route.path,
2727
title: route.navMenuItem.title ?? route.path,
2828
order: route.navMenuItem.order,
29+
requiresPermission: route.navMenuItem.requiresPermission,
30+
icon: route.navMenuItem.icon,
31+
placement: route.navMenuItem.placement,
2932
};
3033
addNavMenuItem(item, route.navMenuItem.sectionId);
3134
}

packages/dev-server/test-plugins/reviews/dashboard/review-list.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ export const reviewList: DashboardRouteDefinition = {
3838
id: 'reviews',
3939
url: '/reviews',
4040
title: 'Product Reviews',
41+
requiresPermission: ['ReadCatalog'],
4142
},
4243
path: '/reviews',
4344
loader: () => ({

0 commit comments

Comments
 (0)