Use aws lambda v2 #354
Merged
Use aws lambda v2 #354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MahdiBM
commented
Jun 1, 2025
Comment on lines
+19
to
+21
| struct SharedContext { | ||
| let awsClient: AWSClient | ||
| } |
There was a problem hiding this comment.
These SharedContexts don't get initialized multiple times across multiple lambda invocations. That's the reason.
MahdiBM
commented
Jun 1, 2025
Comment on lines
+33
to
+37
| .package( | ||
| url: "https://github.com/swift-server/swift-aws-lambda-runtime.git", | ||
| /// Last commit on main as of this code change; V2 | ||
| revision: "c7df9bcd8af279c70f991f5d53e48d73d3e6821a" | ||
| ), |
MahdiBM
commented
Jun 1, 2025
| @@ -319,7 +318,7 @@ | |||
| { | |||
| "identity" : "swift-openapi-async-http-client", | |||
| "kind" : "remoteSourceControl", | |||
| "location" : "https://github.com/swift-server/swift-openapi-async-http-client.git", | |||
| "location" : "https://github.com/swift-server/swift-openapi-async-http-client", | |||
There was a problem hiding this comment.
why the change?! we use .git in Package.swift.
MahdiBM
force-pushed
the
mmbm-aws-lambda-v2
branch
from
8cb5e3c to
5c200b5
Compare
MahdiBM
force-pushed
the
mmbm-aws-lambda-v2
branch
from
5c200b5 to
7dd3567
Compare
0xTim
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #270