Having issue migrating from go-redis to valkey-go

[royatanu94]

Currently we have used :
rcOptions = &redis.UniversalOptions{
rc = redis.NewUniversalClient(rcOptions)
and
func GetRedisClient(conf *RedisConfig) (redis.UniversalClient, error)

What will be the compatible code for above two in valkey-go?

[zuiderkwast]

I don't know the answer to your question, but I know valkey-go is a fork of rueidis, not of go-redis. (Though there are discussions about forking go-redis too.)

@rueian FYI

[rueian]

Yes, it should support.

[royatanu94]

@rueian Is there any change in kpi metrics & logs format in valkey ? I assume log format kept same e.g. "1:M 23 Aug 2024 09:17:52.678 # Server initialized" but metrics are replaced with redis to valkey e.g. "redis_connected_slaves" to "valkey_connected_slaves" right? Is there any other change?

[rueian]

Hi @royatanu94, I believe you should ask the maintainers of https://github.com/oliver006/redis_exporter directly.

[royatanu94]

@rueian redis-exporter supports this since redis 7.0.15, but wanted to ensure any kpi metrics name explicitly changed in valkey or not, also the log format of valkey server got changed or not.

[zuiderkwast]

@royatanu94 The log format didn't change. Most of the messages are the same too. We only changed some log messages which contain the name "redis".

What do you mean by KPI metrics in Valkey?

INFO, MEMORY STATS and similar commands didn't change. Only some field which are called "redis_version" or similar are changed in this way: We report the open source redis version we're compatible with and add another field for the valkey version.

[rueian]

Hi @royatanu94, @zuiderkwast

The compatible code will be using valkeycompat:

package main

import (
	"context"
	"time"
	"github.com/valkey-io/valkey-go"
	"github.com/valkey-io/valkey-go/valkeycompat"
)

func main() {
	ctx := context.Background()
	client, err := valkey.NewClient(valkey.ClientOption{InitAddress: []string{"127.0.0.1:6379"}})
	if err != nil {
		panic(err)
	}
	defer client.Close()

	compat := valkeycompat.NewAdapter(client)
	ok, _ := compat.SetNX(ctx, "key", "val", time.Second).Result()

	// with client side caching
	res, _ := compat.Cache(time.Second).Get(ctx, "key").Result()
}

The adapter is compatible with UniversalClient.

https://github.com/valkey-io/valkey-go/tree/main/valkeycompat

[rueian]

Yes, but I would prefer we just use Github Issues or Discussions.

[royatanu94]

@rueian what is alternate of UniversalClient.Watch in valkey-go adapter?

[rueian]

Hi @royatanu94, the current alternate of UniversalClient.Watch is exactly the same as above https://github.com/valkey-io/valkey-go?tab=readme-ov-file#cas-transaction.

[rueian]

Hi all,

The Pipeliner, Tx, Nil, Script, and Watch are all available in the 1.0.44. Please refer to the https://github.com/valkey-io/valkey-go/blob/main/valkeycompat/README.md for more examples.

[royatanu94]

@rueian
Hi,
In go-redis we used to get below logs when redis connect/disconnect happens.

redis: 2024/07/11 10:53:14 sentinel.go:706: sentinel: new master="master" addr="redis-1.redis.redis-pt-ns.svc.cluster.local:6379"
redis: 2024/07/11 10:53:14 pubsub.go:168: redis: discarding bad PubSub connection: read tcp 10.x.x.0:47226->10.244.x.x:6379: use of closed network connection

Do we have any logs for valkey-go?

[rueian]

Hi @royatanu94,

We don't have logging built-in. Defining a common logging interface in Go is a tough subject and we don't have a good practice yet. Some people don't even want logs at all redis/go-redis#2555, redis/go-redis#250. Currently, if you are interested in logging the use of closed network connection, you could do things like this:

	client, err := valkey.NewClient(valkey.ClientOption{
		InitAddress: []string{"127.0.0.1:6379"},
		DialFn: func(addr string, dialer *net.Dialer, config *tls.Config) (conn net.Conn, err error) {
			conn, err = tls.DialWithDialer(dialer, "tcp", addr, config)
			conn = &LoggedConn{conn: conn} // log errors
			return conn, err
		},
	})