Retrieve latest vagrant version if not specified (#36)

Identify the latest vagrant version available without needing vagrant
installed by querying hashicorp's provided remote API for the current
version the tool available.

Author: electrofelix

.github/workflows/distro-install.yml

@@ -40,7 +40,7 @@ jobs:
         echo "QA_VAGRANT_LIBVIRT_VERSION=git-$(git submodule status -- vagrant-libvirt | cut -d' ' -f2)" >> ${GITHUB_ENV}
     - name: Set up libvirt
       run: |
-        ./scripts/install.bash --vagrant-only -- 2.2.19
+        ./scripts/install.bash --vagrant-only
     - uses: actions/[email protected]
       with:
         path: ~/.vagrant.d/boxes

Vagrantfile

@@ -7,7 +7,7 @@ require_relative './boxes.rb'
 
 def add_test_provisions(vm)
   # Workarond for Vagrant bug
-  if Gem::Version.new(QA_VAGRANT_VERSION) < Gem::Version.new('1.9.1')
+  if Gem::Version.new(Vagrant::VERSION) < Gem::Version.new('1.9.1')
     vm.provision :shell, :inline => <<-EOC
     for i in /opt/vagrant/embedded/gems/gems/vagrant-*/plugins/guests/tinycore/guest.rb
     do

boxes.rb

@@ -1,18 +1,5 @@
 #!/usr/bin/ruby
 #
-# Allow for passing test versions with env vars
-if ENV['QA_VAGRANT_VERSION'].nil? || ENV['QA_VAGRANT_VERSION'] == "latest"
-  # If not specified, fetch the latest version using built-in 'version' plugin
-  #
-  # NOTE: we 'cd /tmp' to avoid invoking Vagrant against this very Vagrantfile but
-  # that may not always work. There is probably a better way by leveraging
-  # VagrantPlugins::CommandVersion::Command and using 'version-latest'
-  # 
-  latest = `cd /tmp; vagrant version | grep Latest | awk '{ print $3 }'`
-  QA_VAGRANT_VERSION = latest.strip
-else
-  QA_VAGRANT_VERSION = ENV['QA_VAGRANT_VERSION']
-end
 
 APT_ENV_VARS = {
   'DEBIAN_FRONTEND': 'noninteractive',
@@ -83,7 +70,7 @@
 }
 
 DEFAULT_PROVISION = [
-  {:name => 'install script', :privileged => false, :path => './scripts/install.bash', :args => "--vagrant-version #{QA_VAGRANT_VERSION}", :env => INSTALL_ENV_VARS},
+  {:name => 'install script', :privileged => false, :path => './scripts/install.bash', :args => ENV['QA_VAGRANT_VERSION'].nil? ? "" : "--vagrant-version #{ENV['QA_VAGRANT_VERSION']}", :env => INSTALL_ENV_VARS},
   {:name => 'setup group', :reset => true, :inline => 'usermod -a -G libvirt vagrant'},
   {:name => 'debug system capabilities', :privileged => false, :inline => 'virsh --connect qemu:///system capabilities'},
   {:name => 'debug uri', :privileged => false, :inline => 'virsh uri'},

scripts/install.bash

@@ -47,6 +47,7 @@ function setup_arch() {
         pkg-config \
         qemu \
         ruby \
+        wget \
         ;
     sudo systemctl enable --now libvirtd
 }
@@ -332,6 +333,8 @@ function install_vagrant() {
     local distro=${2}
     local distro_version=${3:-}
 
+    echo "Installing vagrant version '${version}'"
+
     eval install_vagrant_${distro} ${version}
 
     if [[ -n "${distro_version}" ]] && [[ $(type -t patch_vagrant_${distro}_${distro_version} 2>/dev/null) == 'function' ]]
@@ -409,24 +412,21 @@ while true; do
     esac
 done
 
-if [[ -z ${VAGRANT_VERSION+x} ]]
-then
-    if [[ $# -ne 1 ]]
-    then
-        echo "$0: must specify the version of vagrant to install."
-        exit 4
-    fi
-
-    VAGRANT_VERSION=$1
-fi
-
 echo "Starting vagrant-libvirt installation script"
 
 DISTRO=${DISTRO:-$(awk -F= '/^ID=/{print $2}' /etc/os-release | tr -d '"' | tr '[A-Z]' '[a-z]')}
 DISTRO_VERSION=${DISTRO_VERSION:-$(awk -F= '/^VERSION_ID/{print $2}' /etc/os-release | tr -d '"' | tr '[A-Z]' '[a-z]' | tr -d '.')}
 
 [[ ${VAGRANT_ONLY} -eq 0 ]] && setup_distro ${DISTRO} ${DISTRO_VERSION}
 
+if [[ -z ${VAGRANT_VERSION+x} ]]
+then
+    VAGRANT_VERSION="$(
+        wget -qO - https://checkpoint-api.hashicorp.com/v1/check/vagrant 2>/dev/null | \
+            tr ',' '\n' | grep current_version | cut -d: -f2 | tr -d '"'
+        )"
+fi
+
 install_vagrant ${VAGRANT_VERSION} ${DISTRO} ${DISTRO_VERSION}
 
 [[ ${VAGRANT_ONLY} -eq 0 ]] && install_vagrant_libvirt ${DISTRO}