Skip to content

Commit aa048b2

Browse files
committed
refactor(array): update
1 parent d1df210 commit aa048b2

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

src/draft.ts

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -128,13 +128,13 @@ const proxyHandler: ProxyHandler<ProxyDraft> = {
128128
(value === peek(target.original, key) ||
129129
target.options.skipFinalization!.has(value))
130130
) {
131-
const has = target.options.skipFinalization!.has(value);
132-
if (target.options.skipFinalization!.has(value)) {
131+
const shouldSkip = target.options.skipFinalization!.has(value);
132+
if (shouldSkip) {
133133
target.options.skipFinalization!.delete(value);
134134
}
135135
ensureShallowCopy(target);
136136
target.copy![key] = createDraft({
137-
original: has ? target.copy![key] : target.original[key],
137+
original: shouldSkip ? target.copy![key] : target.original[key],
138138
parentDraft: target,
139139
key: target.type === DraftType.Array ? Number(key) : key,
140140
finalities: target.finalities,
@@ -153,9 +153,6 @@ const proxyHandler: ProxyHandler<ProxyDraft> = {
153153
if (arrayHandling && !isDraft(value) && isDraftable(value)) {
154154
target.options.skipFinalization!.add(value);
155155
}
156-
if (!arrayHandling && target.options.skipFinalization!.has(value)) {
157-
target.options.skipFinalization!.delete(value);
158-
}
159156
return value;
160157
},
161158
set(target: ProxyDraft, key: string | number | symbol, value: any) {

src/utils/finalize.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export function handleValue(
2222
!isDraftable(target, options) ||
2323
handledSet.has(target) ||
2424
Object.isFrozen(target) ||
25-
options?.skipFinalization!.has(target)
25+
(options!.skipFinalization!.has(target))
2626
)
2727
return;
2828
const isSet = target instanceof Set;

0 commit comments

Comments
 (0)