Skip to content

Commit fd348de

Browse files
committed
Update docs to markdown style guide.
1 parent de1a7aa commit fd348de

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

88 files changed

+1352
-1414
lines changed

CONTRIBUTING.md

Lines changed: 13 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -24,16 +24,11 @@ Issues and merge requests should be in English and contain appropriate language
2424

2525
To get support for your particular problem please use the channels as detailed in the [getting help section of the readme](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/README.md#getting-help). Professional [support subscriptions](http://www.gitlab.com/subscription/) and [consulting services](http://www.gitlab.com/consultancy/) are available from [GitLab.com](http://www.gitlab.com/).
2626

27-
The [issue tracker](https://gitlab.com/gitlab-org/gitlab-ce/issues) is only for obvious errors in the latest [stable or development release of GitLab](MAINTENANCE.md).
28-
If something is wrong but it is not a regression compared to older versions of GitLab please do not open an issue but a feature request.
29-
When submitting an issue please conform to the issue submission guidelines listed below.
30-
Not all issues will be addressed and your issue is more likely to be addressed if you submit a merge request which partially or fully addresses the issue.
27+
The [issue tracker](https://gitlab.com/gitlab-org/gitlab-ce/issues) is only for obvious errors in the latest [stable or development release of GitLab](MAINTENANCE.md). If something is wrong but it is not a regression compared to older versions of GitLab please do not open an issue but a feature request. When submitting an issue please conform to the issue submission guidelines listed below. Not all issues will be addressed and your issue is more likely to be addressed if you submit a merge request which partially or fully addresses the issue.
3128

3229
Issues can be filed either at [gitlab.com](https://gitlab.com/gitlab-org/gitlab-ce/issues) or [github.com](https://github.com/gitlabhq/gitlabhq/issues).
3330

34-
Do not use the issue tracker for feature requests.
35-
We have a specific [feature request forum](http://feedback.gitlab.com) for this purpose.
36-
Please keep feature requests as small and simple as possible, complex ones might be edited to make them small and simple.
31+
Do not use the issue tracker for feature requests. We have a specific [feature request forum](http://feedback.gitlab.com) for this purpose. Please keep feature requests as small and simple as possible, complex ones might be edited to make them small and simple.
3732

3833
Please send a merge request with a tested solution or a merge request with a failing test instead of opening an issue if you can. If you're unsure where to post, post to the [mailing list](https://groups.google.com/forum/#!forum/gitlabhq) or [Stack Overflow](http://stackoverflow.com/questions/tagged/gitlab) first. There are a lot of helpful GitLab users there who may be able to help you quickly. If your particular issue turns out to be a bug, it will find its way from there.
3934

@@ -42,16 +37,16 @@ Please send a merge request with a tested solution or a merge request with a fai
4237
**[Search the issues](https://gitlab.com/gitlab-org/gitlab-ce/issues)** for similar entries before submitting your own, there's a good chance somebody else had the same issue. Show your support with `:+1:` and/or join the discussion. Please submit issues in the following format (as the first post):
4338

4439
1. **Summary:** Summarize your issue in one sentence (what goes wrong, what did you expect to happen)
45-
2. **Steps to reproduce:** How can we reproduce the issue, preferably on the [GitLab development virtual machine with vagrant](https://gitlab.com/gitlab-org/cookbook-gitlab/blob/master/doc/development.md) (start your issue with: `vagrant destroy && vagrant up && vagrant ssh`)
46-
3. **Expected behavior:** Describe your issue in detail
47-
4. **Observed behavior**
48-
5. **Relevant logs and/or screenshots:** Please use code blocks (\`\`\`) to format console output, logs, and code as it's very hard to read otherwise.
49-
6. **Output of checks**
40+
1. **Steps to reproduce:** How can we reproduce the issue, preferably on the [GitLab development virtual machine with vagrant](https://gitlab.com/gitlab-org/cookbook-gitlab/blob/master/doc/development.md) (start your issue with: `vagrant destroy && vagrant up && vagrant ssh`)
41+
1. **Expected behavior:** Describe your issue in detail
42+
1. **Observed behavior**
43+
1. **Relevant logs and/or screenshots:** Please use code blocks (\`\`\`) to format console output, logs, and code as it's very hard to read otherwise.
44+
1. **Output of checks**
5045
* Results of GitLab [Application Check](doc/install/installation.md#check-application-status) (`sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production`); we will only investigate if the tests are passing
5146
* Version of GitLab you are running; we will only investigate issues in the latest stable and development releases as per the [maintenance policy](MAINTENANCE.md)
5247
* Add the last commit sha1 of the GitLab version you used to replicate the issue (obtainable from the help page)
5348
* Describe your setup (use relevant parts from `sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`)
54-
7. **Possible fixes**: If you can, link to the line of code that might be responsible for the problem
49+
1. **Possible fixes**: If you can, link to the line of code that might be responsible for the problem
5550

5651
## Merge requests
5752

@@ -87,10 +82,10 @@ For examples of feedback on merge requests please look at already [closed merge
8782
**Please format your merge request description as follows:**
8883

8984
1. What does this MR do?
90-
2. Are there points in the code the reviewer needs to double check?
91-
3. Why was this MR needed?
92-
4. What are the relevant issue numbers / [Feature requests](http://feedback.gitlab.com/)?
93-
5. Screenshots (If appropiate)
85+
1. Are there points in the code the reviewer needs to double check?
86+
1. Why was this MR needed?
87+
1. What are the relevant issue numbers / [Feature requests](http://feedback.gitlab.com/)?
88+
1. Screenshots (If appropiate)
9489

9590
## Contribution acceptance criteria
9691

@@ -106,6 +101,7 @@ For examples of feedback on merge requests please look at already [closed merge
106101
1. It conforms to the following style guides
107102

108103
## Style guides
104+
109105
1. [Ruby](https://github.com/bbatsov/ruby-style-guide)
110106
1. [Rails](https://github.com/bbatsov/rails-style-guide)
111107
1. [Formatting](https://github.com/thoughtbot/guides/tree/master/style#formatting)

MAINTENANCE.md

Lines changed: 6 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,14 @@
11
# GitLab Maintenance Policy
22

3-
GitLab is a fast moving and evolving project. We currently don't have the
4-
resources to support many releases concurrently. We support exactly one stable
5-
release at any given time.
3+
GitLab is a fast moving and evolving project. We currently don't have the resources to support many releases concurrently. We support exactly one stable release at any given time.
64

7-
GitLab follows the [Semantic Versioning](http://semver.org/) for its releases:
8-
`(Major).(Minor).(Patch)`.
5+
GitLab follows the [Semantic Versioning](http://semver.org/) for its releases: `(Major).(Minor).(Patch)`.
96

10-
* **Major version**: Whenever there is something significant or any backwards
11-
incompatible changes are introduced to the public API.
12-
* **Minor version**: When new, backwards compatible functionality is introduced
13-
to the public API or a minor feature is introduced, or when a set of smaller
14-
features is rolled out.
15-
* **Patch number**: When backwards compatible bug fixes are introduced that fix
16-
incorrect behavior.
7+
- **Major version**: Whenever there is something significant or any backwards incompatible changes are introduced to the public API.
8+
- **Minor version**: When new, backwards compatible functionality is introduced to the public API or a minor feature is introduced, or when a set of smaller features is rolled out.
9+
- **Patch number**: When backwards compatible bug fixes are introduced that fix incorrect behavior.
1710

18-
The current stable release will receive security patches and bug fixes
19-
(eg. `5.0` -> `5.0.1`). Feature releases will mark the next supported stable
20-
release where the minor version is increased numerically by increments of one
21-
(eg. `5.0 -> 5.1`).
11+
The current stable release will receive security patches and bug fixes (eg. `5.0` -> `5.0.1`). Feature releases will mark the next supported stable release where the minor version is increased numerically by increments of one (eg. `5.0 -> 5.1`).
2212

2313
We encourage everyone to run the latest stable release to ensure that you can easily upgrade to the most secure and feature rich GitLab experience. In order to make sure you can easily run the most recent stable release, we are working hard to keep the update process simple and reliable.
2414

PROCESS.md

Lines changed: 16 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,9 @@ Below we describe the contributing process to GitLab for two reasons. So that co
2424
## Priorities of the issue team
2525

2626
1. Mentioning people (critical)
27-
2. Workflow labels (normal)
28-
3. Functional labels (minor)
29-
4. Assigning issues (avoid if possible)
27+
1. Workflow labels (normal)
28+
1. Functional labels (minor)
29+
1. Assigning issues (avoid if possible)
3030

3131
## Mentioning people
3232

@@ -36,11 +36,11 @@ The most important thing is making sure valid issues receive feedback from the d
3636

3737
Workflow labels are purposely not very detailed since that would be hard to keep updated as you would need to reevaluate them after every comment. We optionally use functional labels on demand when want to group related issues to get an overview (for example all issues related to RVM, to tackle them in one go) and to add details to the issue.
3838

39-
- _Awaiting feedback_: Feedback pending from the reporter
40-
- _Awaiting confirmation of fix_: The issue should already be solved in **master** (generally you can avoid this workflow item and just close the issue right away)
41-
- _Attached MR_: There is a MR attached and the discussion should happen there
42-
- We need to let issues stay in sync with the MR's. We can do this with a "Closing #XXXX" or "Fixes #XXXX" comment in the MR. We can't close the issue when there is a merge request because sometimes a MR is not good and we just close the MR, then the issue must stay.
43-
- _Awaiting developer action/feedback_: Issue needs to be fixed or clarified by a developer
39+
- *Awaiting feedback*: Feedback pending from the reporter
40+
- *Awaiting confirmation of fix*: The issue should already be solved in **master** (generally you can avoid this workflow item and just close the issue right away)
41+
- *Attached MR*: There is a MR attached and the discussion should happen there
42+
- We need to let issues stay in sync with the MR's. We can do this with a "Closing #XXXX" or "Fixes #XXXX" comment in the MR. We can't close the issue when there is a merge request because sometimes a MR is not good and we just close the MR, then the issue must stay.
43+
- *Awaiting developer action/feedback*: Issue needs to be fixed or clarified by a developer
4444

4545
## Functional labels
4646

@@ -51,12 +51,13 @@ These labels describe what development specialities are involved such as: Postgr
5151
If an issue is complex and needs the attention of a specific person, assignment is a good option but assigning issues might discourage other people from contributing to that issue. We need all the contributions we can get so this should never be discouraged. Also, an assigned person might not have time for a few weeks, so others should feel free to takeover.
5252

5353
## Label colors
54-
- Light orange `#fef2c0`: workflow labels for issue team members (awaiting feedback, awaiting confirmation of fix)
55-
- Bright orange `#eb6420`: workflow labels for core team members (attached MR, awaiting developer action/feedback)
56-
- Light blue `#82C5FF`: functional labels
57-
- Green labels `#009800`: issues that can generally be ignored. For example, issues given the following labels normally can be closed immediately:
58-
- Feature request (see copy & paste response: [Feature requests](#feature-requests))
59-
- Support (see copy & paste response: [Support requests and configuration questions](#support-requests-and-configuration-questions)
54+
55+
- Light orange `#fef2c0`: workflow labels for issue team members (awaiting feedback, awaiting confirmation of fix)
56+
- Bright orange `#eb6420`: workflow labels for core team members (attached MR, awaiting developer action/feedback)
57+
- Light blue `#82C5FF`: functional labels
58+
- Green labels `#009800`: issues that can generally be ignored. For example, issues given the following labels normally can be closed immediately:
59+
- Feature request (see copy & paste response: [Feature requests](#feature-requests))
60+
- Support (see copy & paste response: [Support requests and configuration questions](#support-requests-and-configuration-questions)
6061

6162
## Be kind
6263

@@ -102,8 +103,4 @@ This merge request has been closed because a request for more information has no
102103

103104
### Accepting merge requests
104105

105-
Is there a request on [the feature request forum](http://feedback.gitlab.com/forums/176466-general) that is similar to this?
106-
If so, can you make a comment with a link to it?
107-
Please be aware that new functionality that is not marked [accepting merge/pull requests](http://feedback.gitlab.com/forums/176466-general/status/796455) on the forum might not make it into GitLab.
108-
You might be asked to make changes and even after implementing them your feature might still be declined.
109-
If you want to reduce the chance of this happening please have a discussion in the forum first.
106+
Is there a request on [the feature request forum](http://feedback.gitlab.com/forums/176466-general) that is similar to this? If so, can you make a comment with a link to it? Please be aware that new functionality that is not marked [accepting merge/pull requests](http://feedback.gitlab.com/forums/176466-general/status/796455) on the forum might not make it into GitLab. You might be asked to make changes and even after implementing them your feature might still be declined. If you want to reduce the chance of this happening please have a discussion in the forum first.

0 commit comments

Comments
 (0)