Switch to much stricter linting, fix all lint errors discovered.

Author: developit

.editorconfig

@@ -0,0 +1,15 @@
+root = true
+
+[*]
+indent_style = tab
+end_of_line = lf
+charset = utf-8
+trim_trailing_whitespace = true
+insert_final_newline = true
+
+[{package.json,.*rc,*.yml}]
+indent_style = space
+indent_size = 2
+
+[*.md]
+trim_trailing_whitespace = false

.eslintrc

@@ -1,6 +1,50 @@
 {
   "parser": "babel-eslint",
+  "extends": "eslint:recommended",
+  "env": {
+    "browser": true
+  },
+  "ecmaFeatures": {
+    "modules": true,
+    "jsx": true
+  },
   "rules": {
-    "strict": 0
+    "no-unused-vars": [1, { "varsIgnorePattern": "^h$" }],
+    "no-cond-assign": 1,
+    "semi": 2,
+    "camelcase": 0,
+    "comma-style": 2,
+    "comma-dangle": [2, "never"],
+    "indent": [2, "tab", {"SwitchCase": 1}],
+    "no-mixed-spaces-and-tabs": [2, "smart-tabs"],
+    "no-trailing-spaces": [2, { "skipBlankLines": true }],
+    "max-nested-callbacks": [2, 3],
+    "no-eval": 2,
+    "no-implied-eval": 2,
+    "no-new-func": 2,
+    "guard-for-in": 2,
+    "eqeqeq": 2,
+    "no-else-return": 2,
+    "no-redeclare": 2,
+    "no-dupe-keys": 2,
+    "radix": 2,
+    "strict": [2, "never"],
+    "no-shadow": 0,
+    "callback-return": [1, ["callback", "cb", "next", "done"]],
+    "no-delete-var": 2,
+    "no-undef-init": 2,
+    "no-shadow-restricted-names": 2,
+    "handle-callback-err": 0,
+    "no-lonely-if": 2,
+    "space-return-throw-case": 2,
+    "constructor-super": 2,
+    "no-this-before-super": 2,
+    "no-dupe-class-members": 2,
+    "no-const-assign": 2,
+    "prefer-spread": 2,
+    "no-useless-concat": 2,
+    "no-var": 2,
+    "object-shorthand": 2,
+    "prefer-arrow-callback": 2
   }
 }

karma.conf.js

@@ -14,7 +14,7 @@ module.exports = function(config) {
 
 		preprocessors: {
 			'test/**/*.js': ['webpack'],
-	        'src/**/*.js': ['webpack'],
+			'src/**/*.js': ['webpack'],
 			'**/*.js': ['sourcemap']
 		},
 

src/preact.js

@@ -559,8 +559,8 @@ function build(dom, vnode) {
 				dom.textContent = vnode;
 				return dom;
 			}
-			else {
-				if (dom.nodeType===1) recycler.collect(dom);
+			else if (dom.nodeType===1) {
+				recycler.collect(dom);
 			}
 		}
 		return document.createTextNode(vnode);
@@ -769,7 +769,7 @@ let renderQueue = {
 /** Trigger all queued component renders.
  *	@function
  */
-let rerender = renderQueue.process
+let rerender = renderQueue.process;
 
 
 
@@ -805,7 +805,7 @@ let recycler = {
 		// remove event listeners & registry
 		let l = node._listeners;
 		delete node._listeners;
-		if (l) for (let i in l) node.removeEventListener(i, eventProxy);
+		if (l) for (let i in l) if (hop.call(l, i)) node.removeEventListener(i, eventProxy);
 
 		// strip attributes
 		let len = node.attributes && node.attributes.length;

test/browser/render.js

@@ -1,10 +1,13 @@
 import { h, render, rerender, Component } from '../../src/preact';
 let { expect } = chai;
 
+/*eslint-env browser, mocha */
+/*global sinon, chai*/
+
 /** @jsx h */
 
 describe('render()', () => {
-	var scratch;
+	let scratch;
 
 	before( () => {
 		scratch = document.createElement('div');
@@ -37,7 +40,7 @@ describe('render()', () => {
 
 		render(<foo />, scratch);
 		render(<x-bar />, scratch);
-		expect(scratch.childNodes).to.have.length(2)
+		expect(scratch.childNodes).to.have.length(2);
 		expect(scratch.childNodes[0]).to.have.property('nodeName', 'FOO');
 		expect(scratch.childNodes[1]).to.have.property('nodeName', 'X-BAR');
 	});
@@ -56,9 +59,9 @@ describe('render()', () => {
 			.and.to.have.deep.property('0.nodeName', 'DIV');
 
 		let c = scratch.childNodes[0].childNodes;
-		expect(c).to.have.length(3)
-		expect(c).to.have.deep.property('0.nodeName', 'SPAN')
-		expect(c).to.have.deep.property('1.nodeName', 'FOO')
+		expect(c).to.have.length(3);
+		expect(c).to.have.deep.property('0.nodeName', 'SPAN');
+		expect(c).to.have.deep.property('1.nodeName', 'FOO');
 		expect(c).to.have.deep.property('2.nodeName', 'X-BAR');
 	});
 
@@ -94,8 +97,7 @@ describe('render()', () => {
 
 	it('should only register on* functions as handlers', () => {
 		let click = () => {},
-			onclick = () => {},
-			calls = [];
+			onclick = () => {};
 
 		let proto = document.createElement('div').constructor.prototype;
 

test/shared/exports.js

@@ -1,6 +1,8 @@
 import { expect } from 'chai';
 import { default as preact, h, render, Component, hooks, options } from '../../src/preact';
 
+/*eslint-env browser, mocha */
+
 describe('preact', () => {
 	it('should be available as a default export', () => {
 		expect(preact).to.be.an('object');

test/shared/h.js

@@ -1,13 +1,15 @@
 import { expect } from 'chai';
 import { h, VNode } from '../../src/preact';
 
+/*eslint-env browser, mocha */
+
 /** @jsx h */
 
 let flatten = obj => JSON.parse(JSON.stringify(obj));
 
 describe('h(jsx)', () => {
 	it('should return a VNode', () => {
-		var r;
+		let r;
 		expect( () => r = h('foo') ).not.to.throw();
 		expect(r).to.be.an('object');
 		expect(r).to.be.an.instanceof(VNode);