Skip to content

Commit dcf94b9

Browse files
authored
Use yarn instead of npm to install JS dependencies (#142)
## What is the goal of this PR? We replaced `npm install` in our Bazel build system with `yarn` to align with our other NodeJS projects. ## What are the changes implemented in this PR? Use yarn instead of npm to install JS dependencies
1 parent 008f0fc commit dcf94b9

File tree

4 files changed

+674
-779
lines changed

4 files changed

+674
-779
lines changed

WORKSPACE

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -117,13 +117,13 @@ workspace_refs(
117117

118118
load("@vaticle_dependencies//builder/nodejs:deps.bzl", nodejs_deps = "deps")
119119
nodejs_deps(["@vaticle_dependencies//builder/nodejs:remove-node-patches.patch"])
120-
load("@build_bazel_rules_nodejs//:index.bzl", "node_repositories", "npm_install")
120+
load("@build_bazel_rules_nodejs//:index.bzl", "node_repositories", "yarn_install")
121121

122122
node_repositories(
123123
preserve_symlinks = False,
124124
)
125-
npm_install(
125+
yarn_install(
126126
name = "npm",
127127
package_json = "//grpc/nodejs:package.json",
128-
package_lock_json = "//grpc/nodejs:package-lock.json",
128+
yarn_lock = "//grpc/nodejs:yarn.lock",
129129
)

grpc/nodejs/BUILD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ checkstyle_test(
8585
include = glob(["*"]),
8686
exclude = [
8787
"package.json",
88-
"package-lock.json",
88+
"yarn.lock",
8989
],
9090
license_type = "agpl",
9191
size = "small",

0 commit comments

Comments
 (0)