Skip to content

Commit 84a1eb7

Browse files
authored
Explanation Conclusion should include non-retrievable concepts (#157)
## What is the goal of this PR? Introduce a different answer type for conclusions inside explanations. This permits returning any concept, not only retrievable concepts, which is important for returning a thorough explanation due to unification. ## What are the changes implemented in this PR? - Swap `ConceptMap` for a `map`
1 parent 5383b21 commit 84a1eb7

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

common/BUILD

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,10 @@ proto_library(
3333
proto_library(
3434
name = "logic-proto",
3535
srcs = ["logic.proto"],
36-
deps = [":answer-proto"]
36+
deps = [
37+
":answer-proto",
38+
":concept-proto"
39+
],
3740
)
3841

3942
proto_library(

common/logic.proto

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ option java_package = "com.vaticle.typedb.protocol";
2121
option java_outer_classname = "LogicProto";
2222

2323
import "common/answer.proto";
24+
import "common/concept.proto";
2425

2526

2627
package typedb.protocol;
@@ -114,7 +115,7 @@ message Explanation {
114115
Rule rule = 1;
115116
map<string, VarList> var_mapping = 2;
116117
ConceptMap condition = 3;
117-
ConceptMap conclusion = 4;
118+
map<string, Concept> conclusion = 4;
118119

119120
message VarList {
120121
repeated string vars = 1;

0 commit comments

Comments
 (0)