Skip to content

Commit 1683f49

Browse files
Remove implicits (#32)
## What is the goal of this PR? Previously, we could use `relHas` messages to access the implicit relations used for `has` -- this is no longer an allowed functionality, we only use `has` messages directly now. ## What are the changes implemented in this PR? * Replace `relHas` with `has` as appropriate
1 parent 2777c5e commit 1683f49

File tree

1 file changed

+4
-16
lines changed

1 file changed

+4
-16
lines changed

session/Concept.proto

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ message Method {
2929
Concept.Delete.Req concept_delete_req = 100;
3030

3131
// SchemaConcept method requests
32-
SchemaConcept.IsImplicit.Req schemaConcept_isImplicit_req = 200;
3332
SchemaConcept.GetLabel.Req schemaConcept_getLabel_req = 201;
3433
SchemaConcept.SetLabel.Req schemaConcept_setLabel_req = 202;
3534
SchemaConcept.GetSup.Req schemaConcept_getSup_req = 203;
@@ -67,7 +66,7 @@ message Method {
6766
// Thing method requests
6867
Thing.Type.Req thing_type_req = 900;
6968
Thing.IsInferred.Req thing_isInferred_req = 901;
70-
Thing.Relhas.Req thing_relhas_req = 906;
69+
Thing.Has.Req thing_has_req = 906;
7170
Thing.Unhas.Req thing_unhas_req = 907;
7271

7372
// Relation method requests
@@ -84,7 +83,6 @@ message Method {
8483
Concept.Delete.Res concept_delete_res = 100;
8584

8685
// SchemaConcept method responses
87-
SchemaConcept.IsImplicit.Res schemaConcept_isImplicit_res = 200;
8886
SchemaConcept.GetLabel.Res schemaConcept_getLabel_res = 201;
8987
SchemaConcept.SetLabel.Res schemaConcept_setLabel_res = 202;
9088
SchemaConcept.GetSup.Res schemaConcept_getSup_res = 203;
@@ -122,7 +120,7 @@ message Method {
122120
// Thing method responses
123121
Thing.Type.Res thing_type_res = 900;
124122
Thing.IsInferred.Res thing_isInferred_res = 901;
125-
Thing.Relhas.Res thing_relhas_res = 906;
123+
Thing.Has.Res thing_has_res = 906;
126124
Thing.Unhas.Res thing_unhas_res = 907;
127125

128126
// Relation method responses
@@ -219,7 +217,6 @@ message Concept {
219217
Attribute.Value.Res value_res = 7;
220218
AttributeType.ValueType.Res valueType_res = 8;
221219
SchemaConcept.GetLabel.Res label_res = 9;
222-
SchemaConcept.IsImplicit.Res isImplicit_res = 10;
223220

224221
enum BASE_TYPE {
225222
META_TYPE = 0;
@@ -257,13 +254,6 @@ message SchemaConcept {
257254
message Res {}
258255
}
259256

260-
message IsImplicit {
261-
message Req{}
262-
message Res{
263-
bool implicit = 1;
264-
}
265-
}
266-
267257
message GetSup {
268258
message Req {}
269259
message Res {
@@ -619,13 +609,11 @@ message Thing {
619609
}
620610
}
621611

622-
message Relhas {
612+
message Has {
623613
message Req {
624614
Concept attribute = 1;
625615
}
626-
message Res {
627-
Concept relation = 1;
628-
}
616+
message Res {}
629617
}
630618

631619
message Unhas {

0 commit comments

Comments
 (0)