Improve getSchemaExceptions() to return TypeDBException that contains code and message

Author: haikalpribadi

api/concept/ConceptManager.java

@@ -26,6 +26,7 @@
 import com.vaticle.typedb.client.api.concept.type.EntityType;
 import com.vaticle.typedb.client.api.concept.type.RelationType;
 import com.vaticle.typedb.client.api.concept.type.ThingType;
+import com.vaticle.typedb.client.common.exception.TypeDBException;
 
 import java.util.List;
 import javax.annotation.CheckReturnValue;
@@ -72,5 +73,5 @@ public interface ConceptManager {
     AttributeType putAttributeType(String label, AttributeType.ValueType valueType);
 
     @CheckReturnValue
-    List<String> getSchemaExceptions();
+    List<TypeDBException> getSchemaExceptions();
 }

common/exception/TypeDBException.java

@@ -0,0 +1,34 @@
+/*
+ * Copyright (C) 2022 Vaticle
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package com.vaticle.typedb.client.common.exception;
+
+public class TypeDBException extends RuntimeException {
+
+    public String code;
+    public String message;
+
+    public TypeDBException(String code, String message) {
+        super(message);
+        this.code = code;
+        this.message = message;
+    }
+}

concept/ConceptManagerImpl.java

@@ -28,6 +28,7 @@
 import com.vaticle.typedb.client.api.concept.type.EntityType;
 import com.vaticle.typedb.client.api.concept.type.RelationType;
 import com.vaticle.typedb.client.api.concept.type.ThingType;
+import com.vaticle.typedb.client.common.exception.TypeDBException;
 import com.vaticle.typedb.client.concept.thing.ThingImpl;
 import com.vaticle.typedb.client.concept.type.AttributeTypeImpl;
 import com.vaticle.typedb.client.concept.type.EntityTypeImpl;
@@ -46,6 +47,7 @@
 import static com.vaticle.typedb.client.common.rpc.RequestBuilder.ConceptManager.putAttributeTypeReq;
 import static com.vaticle.typedb.client.common.rpc.RequestBuilder.ConceptManager.putEntityTypeReq;
 import static com.vaticle.typedb.client.common.rpc.RequestBuilder.ConceptManager.putRelationTypeReq;
+import static java.util.stream.Collectors.toList;
 
 public final class ConceptManagerImpl implements ConceptManager {
 
@@ -142,8 +144,9 @@ public Thing getThing(String iid) {
     }
 
     @Override
-    public List<String> getSchemaExceptions() {
-        return execute(getSchemaExceptionsReq()).getGetSchemaExceptionsRes().getExceptionsList();
+    public List<TypeDBException> getSchemaExceptions() {
+        return execute(getSchemaExceptionsReq()).getGetSchemaExceptionsRes().getExceptionsList().stream()
+                .map(e -> new TypeDBException(e.getCode(), e.getMessage())).collect(toList());
     }
 
     private ConceptProto.ConceptManager.Res execute(TransactionProto.Transaction.Req.Builder req) {

dependencies/vaticle/repositories.bzl

@@ -46,7 +46,7 @@ def vaticle_typedb_protocol():
     git_repository(
         name = "vaticle_typedb_protocol",
         remote = "https://github.com/vaticle/typedb-protocol",
-        commit = "26782a597b83c97f55b14428b13207fc5d9b9f18", # sync-marker: do not remove this comment, this is used for sync-dependencies by @vaticle_typedb_protocol
+        commit = "a86f8ffeff1699881c5418c8976315536357a1c8", # sync-marker: do not remove this comment, this is used for sync-dependencies by @vaticle_typedb_protocol
     )
 
 def vaticle_typedb_behaviour():